Recreate venv for each build + install from pylock.toml when available - #345
Open
hugovk wants to merge 3 commits into
Open
Recreate venv for each build + install from pylock.toml when available#345hugovk wants to merge 3 commits into
hugovk wants to merge 3 commits into
Conversation
hugovk
commented
Jul 28, 2026
| venv_path, | ||
| symlinks=os.name != "nt", | ||
| with_pip=True, | ||
| clear=True, |
Member
Author
There was a problem hiding this comment.
This ensures a fresh venv.
| symlinks=os.name != "nt", | ||
| with_pip=True, | ||
| clear=True, | ||
| upgrade_deps=True, |
Member
Author
There was a problem hiding this comment.
Upgrade pip, because otherwise we use the bundled pip, and we need at least 25.1 for pylock.toml support.
Could do this just for the pylock.toml part, but might as well update for both.
ZeroIntensity
approved these changes
Jul 29, 2026
ZeroIntensity
left a comment
Member
There was a problem hiding this comment.
I'm definitely not the most qualified reviewer here, but nothing jumps out at me as wrong (and I really want the highlighting 😃)
Member
Author
|
You'll be happy to hear that Discourse (which uses highlight.js) will also get |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: python/cpython#153227 (comment)
python/cpython#153228 switched to use a dev version of pygments from GitHub, but it's not being picked up on the doc server.
This is because:
pip install --upgrade -rrequirements.txtstill sees pygments with the same version number in the venv, so doesn't need to upgrade itThis PR does two things:
pylock.tomlwhen when available.