Skip to content

Infra: Add ASDL lexer from cpython - #5220

Merged
hugovk merged 5 commits into
python:mainfrom
cdce8p:infra-asdl-lexer
Nov 5, 2026
Merged

hugovk merged 5 commits into
python:mainfrom
cdce8p:infra-asdl-lexer

Conversation

@cdce8p

@cdce8p cdce8p commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Please check if the license header is correct and acceptable before approving the PR.
https://github.com/python/cpython/blob/v3.15.0/Doc/tools/extensions/lexers/asdl_lexer.py

Closes #5214

@read-the-docs-community

read-the-docs-community Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 pep-previews | 🛠️ Build #35656681 | 📁 Comparing be61991 against latest (16991a9)

  🔍 Preview build  

2 files changed
± pep-0823/index.html
± pep-0847/index.html

@gvanrossum

Copy link
Copy Markdown
Member

I'm okay with the code. But I think it's up to @hugovk to merge this.

@hugovk

hugovk commented Nov 4, 2026

Copy link
Copy Markdown
Member

Should https://github.com/python/peps/blob/main/pep_sphinx_extensions/LICENCE.rst mention the licence of this file?

Longer term, perhaps this or similar could be upstreamed to https://github.com/pygments/pygments, then both CPython and PEPs could use that directly. What do you think?

@cdce8p

cdce8p commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor Author

Should https://github.com/python/peps/blob/main/pep_sphinx_extensions/LICENCE.rst mention the licence of this file?

Added something. Let me know if that's what you had in mind.

Longer term, perhaps this or similar could be upstreamed to https://github.com/pygments/pygments, then both CPython and PEPs could use that directly. What do you think?

That could make sense though I don't know if it's popular enough to warrant inclusion upstream if it's just used for cpython and the PEPs repo.

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk
hugovk enabled auto-merge (squash) November 5, 2026 15:21
@hugovk
hugovk merged commit da2bb69 into python:main Nov 5, 2026
21 of 22 checks passed
@cdce8p
cdce8p deleted the infra-asdl-lexer branch November 5, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Infra: Add ASDL lexer from cpython

3 participants