Repository navigation
Lint: Validate every version in the Python-Version header - #5221
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
RaphaelFakhri
requested review from
AA-Turner,
CAM-Gerlach and
hugovk
as code owners
November 5, 2026 09:04
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check-peps.pysplitsPython-Versioninto a comma-separated list, but_validate_python_version()ends withreturnwhen a version has no micro part. The first two-segment version (for example3.12) stops the generator, so later versions in the list are never checked.For example, these headers pass the linter today:
This change replaces the
returnwithcontinue, so each version gets the same checks as a single-version header. It also adds a test for multi-version headers. The existing parametrized test builds the expected message from the whole line, so it only covers single versions.All current PEPs still pass
python check-peps.py.