Repository navigation
chore: update dependencies - #4
Merged
Merged
Conversation
- moq-cli 0.9.5 -> 0.10.0 - @moq/net 0.2.2 -> 0.3.5, @moq/msf 0.2.0 -> 0.2.2, ws 8.22.0, zod 4.6.5, pnpm 10.34.6 - GitHub Actions v4 -> v7/v8 (Node 20 runtime is being retired) - CI now uses moq-relay 0.14.5, same as the Containerfile (was 0.14.3) Newer moq-relay, moq-cli, @moq/net and @moq/msf versions need code changes or make SGAI event loss worse; see CHANGELOG.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each event is its own single-frame group, and the older of two groups written in the same tick can be skipped on the way to the subscriber. The 50 ms gap only existed inside the Start and End pairs, so Ad End could still follow Placement Opportunity Start with no gap (when the ANNOUNCE wait lasts the whole break) and the blackout timer could fire together with Ad End. smoke-test-sgai lost Placement Opportunity Start in every break. Route every emit() through one queue with 50 ms between writes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates dependencies to the newest versions that work without code changes, and fixes lost SGAI events.
Fix: SGAI events sent at the same time could be lost (each event is its own group, and the older one can be skipped).
smoke-test-sgailostPlacement Opportunity Startin every break. The publisher now sends all events through one queue with 50 ms between them.Not updated:
frag_every_frame. Needs new ffmpeg flags.sgai/scripts need a rewrite.Details are in CHANGELOG.md.
Tested locally: lint,
.mjssyntax check, SCTE-35 check, all smoke tests. With the fix,smoke-test-sgaipassed 8 of 8 runs and the SGAI Podman test 10 of 10.