Skip to content

ci: cut runner time without dropping the required checks - #35

Merged
prascli merged 2 commits into
mainfrom
ci/trim-runner-time
Nov 12, 2026
Merged

prascli merged 2 commits into
mainfrom
ci/trim-runner-time

Conversation

@prascli

@prascli prascli commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Runner time, not money: the repository is public, so minutes are free. These changes cut the wall-clock and the queue that every push pays.

What changes

  • CodeQL default setup: languages trimmed from actions, go, javascript, javascript-typescript, python, typescript to go, actions, javascript-typescript. The repository contains no Python, and the JavaScript/TypeScript pair was analysed twice. Three of six analyses per push produced no signal.
  • ci.yml concurrency: ci-<workflow>-<ref> with cancel-in-progress, so a new push supersedes the run it replaced.
  • ci.yml path filter inside the jobs, never at workflow level: a changes job compares the diff (origin/<base>...HEAD for PRs, before..after for pushes) and only the heavy steps are gated on it. The jobs themselves still run and still report test (1.22), test (1.24) and goreleaser-check, because those are the required checks on main and a skipped job leaves them unsatisfied. An unknown diff (new branch, forced push, manual run) runs the Go steps rather than skipping them. Changes to .github/workflows/, go.mod, go.sum, Makefile, action.yml, .goreleaser.yml and scripts/ all count as Go-relevant.
  • setup-go module cache enabled in both matrix legs and the goreleaser job.
  • pages.yml: dropped the separate npm run typecheck, because the export build runs TypeScript itself (its log prints "Running TypeScript"). Lint still runs before the build.

Verification

# the diff filter, run against this branch's own diff
$ git diff --name-only origin/main...HEAD
.github/workflows/ci.yml
.github/workflows/pages.yml
# -> contains .github/workflows/, so go=true and the Go steps run: a CI change
#    has to prove the CI still works

# a website-only diff
$ echo website/DEPLOYMENT.md | grep -qE '(^|/)(.*\.go|go\.mod|go\.sum|Makefile|action\.ya?ml|\.goreleaser\.ya?ml)$|^scripts/|^\.github/workflows/'
$ echo $?
1   # go=false, Go steps skipped, job still reports success

The workflow YAML is exercised by this PR itself: the changes job runs, and because the diff touches .github/workflows/, both test legs and goreleaser-check execute in full. The skip path will be exercised by the next website-only change.

Not done

Workflow-level paths-ignore on ci.yml would skip the jobs entirely and leave the three required checks unreported, which blocks every PR. That is why the filter sits inside the job.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; the previous CI failure is fixed.

Summary

This PR cuts CI work by filtering Go-related changes, caching Go modules, cancelling replaced runs, and removing the separate website typecheck.

  • CI skips unrelated Go work and cancels runs replaced by newer pushes.
  • The Pages build checks TypeScript without a separate typecheck step.

Reviews (2) · Last reviewed commit: "ci: keep full history for the diff and f..." · Reviewed by Greptile

@github-actions github-actions Bot added the ci Workflows, templates and repository automation. label Nov 12, 2026
Comment thread .github/workflows/ci.yml Resolved
@prascli
prascli merged commit 9e3f8e5 into main Nov 12, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Workflows, templates and repository automation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant