Repository navigation
Conversation
`run` returns `ExitCode`, which is itself `#[must_use]`. Clippy in Rust 1.100 reports the attribute as `double_must_use`, and CI runs clippy with `-D warnings` on the current stable toolchain. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 49 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI runs clippy with
-D warningson the current stable toolchain. Rust 1.100 (2026-11-09) reports#[must_use]onzerodb_tools::runasclippy::double_must_use, because the function returnsExitCode, which is already#[must_use]. Every new PR fails the "fmt + clippy + test" job on it (seen on #173).The fix removes the attribute. Callers still get the warning from the return type.
Checked locally with Rust 1.100.0:
cargo clippy --workspace --all-targets -- -D warningsand the-p heed --features unique-txnsrun are clean.🤖 Generated with Claude Code