Skip to content

tools: drop a redundant #[must_use] that clippy 1.100 rejects - #174

Closed
qdequele wants to merge 1 commit into
mainfrom
fix-clippy-1-100
Closed

qdequele wants to merge 1 commit into
mainfrom
fix-clippy-1-100

Conversation

@qdequele

Copy link
Copy Markdown
Owner

CI runs clippy with -D warnings on the current stable toolchain. Rust 1.100 (2026-11-09) reports #[must_use] on zerodb_tools::run as clippy::double_must_use, because the function returns ExitCode, which is already #[must_use]. Every new PR fails the "fmt + clippy + test" job on it (seen on #173).

The fix removes the attribute. Callers still get the warning from the return type.

Checked locally with Rust 1.100.0: cargo clippy --workspace --all-targets -- -D warnings and the -p heed --features unique-txns run are clean.

🤖 Generated with Claude Code

`run` returns `ExitCode`, which is itself `#[must_use]`. Clippy in Rust
1.100 reports the attribute as `double_must_use`, and CI runs clippy with
`-D warnings` on the current stable toolchain.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 49 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4b6a3a76-ad12-4081-a060-a8618d3c9d65
Commits

Reviewing files that changed from the base of the PR and between 9115969 and ec67f1b.

Files selected for processing: 1

  • crates/zerodb-tools/src/lib.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@qdequele qdequele closed this Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant