Repository navigation
fix: return NotFound from DeleteCollection for a missing collection - #181
Merged
anush008 merged 1 commit intoNov 2, 2026
Merged
Conversation
NotFound from DeleteCollection for a missing collection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the collection does not exist, the server answers
DeleteCollectionwithresult: falseand no gRPC error. The client turned that into a plainerrors.New("failed to delete collection"), which has no gRPC status, sostatus.Code(err)returnedcodes.Unknown. Every other method I tried reports a missing collection ascodes.NotFound(GetCollectionInfo,ListSnapshots,Count), so callers could not tell "the collection is already gone" apart from a real failure without matching the error text.DeleteCollectionnow returns aNotFoundstatus error in this case.QdrantErroralready unwraps to its inner error, sostatus.Code(err)andstatus.FromError(err)returnNotFound:The error message changes from:
to:
Behavior change: callers that only check
err != nilare unaffected. Code that matched the old text"failed to delete collection"needs to checkstatus.Code(err) == codes.NotFoundinstead.Fixes #
Changes
qdrant/collections.go: returnstatus.Errorf(codes.NotFound, ...)wrapped inQdrantErrorwhen the server reportsresult: falseqdrant_test/collections_test.go:DeleteNonExistentCollectionnow also checksstatus.Code(err) == codes.NotFoundChecks
go test ./...passes, including the integration testsDeleteNonExistentCollectioncheck fails on master (Unknowninstead ofNotFound) and passes with this changegolangci-lint runreports 0 issuesgofmt -s -l qdrant qdrant_testreports nothingCloses #180