Repository navigation
fix(local): apply offset to prefetched random samples - #1594
Draft
Harsh23Kashyap wants to merge 1 commit into
Draft
Harsh23Kashyap wants to merge 1 commit into
Harsh23Kashyap wants to merge 1 commit into
Conversation
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1593.
Local random sampling ignores
offseteven when it follows a prefetch. With five candidates andoffset=5, local mode returns five points while Qdrant 1.19.2 returns none.Apply the offset after sampling the prefetched candidates, requesting
limit + offsetpoints before slicing. Standalone random queries still ignore offset, as the server does. Other query types keep their existing offset handling.Sync and async regressions cover offsets 0, 2, 4, 5 and 10, with and without a prefetch. Before the fix, six assertions fail and fourteen pass on both runs (1.09s, 1.08s). After the fix, all twenty pass twice (1.02s, 0.96s).
Also ran:
pytest qdrant_client/local/tests tests/test_local_persistence.py tests/test_local_uuid_identity.py tests/test_local_sample_offset.py -q: 271 passed twice (4.19s, 3.72s).I did not run the full repository or model-inference suites. Python 3.12.14, Linux x86_64.
All Submissions:
devbranch. Did you create your branch fromdev?Changes to Core Features: