Repository navigation
add values.schema.json for values validation - #516
Open
ChinmayPande48 wants to merge 2 commits into
Open
ChinmayPande48 wants to merge 2 commits into
ChinmayPande48 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
charts/qdrant/values.schema.jsonso user-provided values are validated onhelm install,helm upgrade,helm templateandhelm lint. It also gives IDEs schema-based completion and hints forvalues.yaml.Closes #513
What's covered
values.yaml, with types for scalars, arrays and maps.image.pullPolicy,service.type, portprotocol, ingresspathType, PVCaccessModes,podManagementPolicy,fsGroupChangePolicy,podDisruptionBudget.unhealthyPodEvictionPolicy.servicePortandconfig.cluster.p2p.port.apiKey/readOnlyApiKeyaccept a boolean, a string, or avalueFrom.secretKeyRefobject, matching the documented options.snapshotRestoration.snapshotsallowsnull, since the default is an empty key.targetPort,servicePortand PDBmaxUnavailable/minAvailableaccept int or string (named ports, percentages).values.yaml(e.g.terminationGracePeriodSeconds,minAvailable,storageClassName) are included.Design decisions
additionalProperties: false, so existing users with extra or custom keys won't see installs break. It can be tightened later if maintainers want that.affinity,resources,lifecycle,sidecarContainers, volume lists, etc.) are typed only asobject/arrayrather than reproducing the full Kubernetes schemas.configis loosely typed. Only the keys already invalues.yamlare typed and the object stays open.Testing
values.yamlvalidates against the schema with no errors.helm lintpasses on the chart.--set replicaCount=abcand--set image.pullPolicy=Sometimes.apiKey,apiKeyviavalueFrom.secretKeyRef, PDBmaxUnavailable: "50%".Happy to extend or tighten it, or add CI values files that exercise it, if you'd like.