Repository navigation
Conversation
Test pod entrypoint writes ~/.curlrc, which fails on a read-only rootfs. Add a chartTests securityContext option to enforce it; stays red until fixed.
Author
|
Hi @bashofmann, Can you help me with this pull request? Your review will be helpful. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #441
What changed
The
helm testpod writes~/.curlrcat startup, which fails on clusters that enforcereadOnlyRootFilesystemon every pod. The test pod now gets a writableemptyDirmounted at/tmp/homeandHOMEpoints to it.Added an optional
chartTests.dbInteraction.containerSecurityContextvalue that is rendered into the test container. It is unset by default, so rendering is unchanged unless you set it.Added an integration test (
readonly_rootfs.bats) that runshelm testwith a read-only root filesystem. It fails without the fix.Testing
make lintmake test-unitmake test-integration(all 28 tests pass)