Repository navigation
Keep credentials out of spank_qrmi logs - #204
Draft
awennersteen wants to merge 1 commit into
Draft
awennersteen wants to merge 1 commit into
awennersteen wants to merge 1 commit into
Conversation
Collaborator
Author
|
Need to look at this more closely. I did close #197 as being out of date. but I think that branch had better ideas. in particular the code needed to implement: QRMI records still pass through Slurm's logging APIs. QRMI |
Remove _dump_environ(), which wrote every environment variable,
including API keys, to the Slurm log at debug level. Log only the
names of environment variables and --env: arguments, and drop
acquisition tokens from debug and error messages.
Ignore {resource}_QRMI_JOB_ACQUISITION_TOKEN in the user's job
environment and export the freshly acquired token with OVERWRITE, so
a job submitted from inside another QPU job cannot reuse (and later
release) the parent's session.
Supersedes #197. Part of #189.
awennersteen
force-pushed
the
aw/protect-credentials
branch
from
October 28, 2026 15:52
e1d3f07 to
361e8f0
Compare
awennersteen
added a commit
that referenced
this pull request
Oct 28, 2026
Build spank_qrmi.c into a test binary with fake Slurm and QRMI functions
and run the plugin hooks the way slurmstepd does for a batch step. The
cases cover --qpu with one or several resources, unknown, inaccessible
and failing resources, --env: plugin arguments, copying {name}_QRMI_*
from the job environment, token export and release, and RUST_LOG from
SRUN_DEBUG.
One case is marked WILL_FAIL because it hits a bug on main: a token
already in the job environment wins over the one just acquired (#204).
CI runs the tests after the first spank_qrmi build, which provides
qrmi.h.
Collaborator
Author
|
Rebased on main. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR was prepared by Claude (an AI coding agent) at the request of @awennersteen. @awennersteen has not reviewed it yet and must review it before it is ready for anyone else.
Description of Change
_dump_environ(), which wrote every environment variable (including API keys) to the Slurm log at debug level.--env:arguments; drop acquisition tokens from debug and error messages.{resource}_QRMI_JOB_ACQUISITION_TOKENfrom the user job environment and export the freshly acquired token withOVERWRITE, so a job submitted from inside another QPU job cannot reuse (and later release) the parent session.Supersedes #197 (whose branch now reverts #202 when compared with main). Part of #189.
Testing
-Wall -Wextraagainst libslurm 23.11.--env:redaction and the token skip.