Repository navigation
Make shell linting fail CI and fix the clang-tidy check name - #206
Merged
Merged
Conversation
The shellcheck and shfmt steps ended in '|| true' and used '**/*.sh', which without globstar never matched the job scripts under demo/qrmi/jobs. Run both on the tracked scripts, with shellcheck at warning severity (the scripts source virtualenvs it cannot follow). All tracked scripts pass both checks. Fix the 'modrnize-*' typo in the clang-tidy checks, and list the pasqal-local, iqm-server and alice-bob-felis resource types in the README.
awennersteen
marked this pull request as ready for review
September 29, 2026 10:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
|| trueand used**/*.sh, which without globstar never matched the scripts indemo/qrmi/jobs. Both now run ongit ls-files "*.sh"and can fail the build (shellcheck at warning severity, since the scripts source virtualenvs it cannot follow). All tracked scripts pass.modrnize-*typo in the clang-tidy checks.pasqal-local,iqm-serverandalice-bob-felis(checked against qrmisrc/models/config.rs).Related to #150: items 1-3 of that issue look fixed on main; item 4 (per-QPU config docs) is still open.
Testing