Repository navigation
Fail the job when a --qpu resource is not in the config - #209
Merged
Merged
Conversation
With --qpu=A,B and B missing from qrmi_config.json, the job still ran with A only, as a failed acquire used to. Treat it the same way: record the error, stop, and let slurm_spank_task_init() cancel the job.
ohtanim
approved these changes
Sep 30, 2026
ohtanim
left a comment
ohtanim
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. This was already on my TODO list as well. I agree that this is a reasonable behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Follow-up to #205;
With
--qpu=A,BandBmissing fromqrmi_config.json, the job still ran withAonly, which is what #205 stopped for a failed acquire. The not-found path now records the error and stops the same way, and slurm_spank_task_init()` cancels the job.Note that this does not handle services or dynamic resources. But, I don't think the current spank_plugins do that anyways? By adding this, we also ensure that we must correctly implement those cases later on.
This is a documented behaviour change: the README used to say unknown resource names are ignored. Its line is rewritten here.