Repository navigation
Update the runtime parameters offered by the tab completion of qlever settings and qlever start - #358
Merged
Merged
Conversation
…r settings` and `qlever start` Add the eleven parameters of the current QLever master that were missing, and the three of the integration branch `geo-cell-integration` (`memory-for-queries`, `geo-prefilter-planning-max-rows`, `geo-prefilter-planning-max-cost`). Drop the five parameters that QLever has renamed in the meantime.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tab completion of
qlever settingsandqlever startoffers the runtime parameters from a fixed list in theQleverfileclass, which has fallen behind https://github.com/ad-freiburg/qlever. This change adds the eleven parameters of the current QLever master that were missing, for examplemax-num-threads-per-query,sort-num-tasks-in-flight, andthrow-on-invalid-wkt. It drops five names that QLever has replaced in the meantime, for exampleparallel-sort-num-threadsbysort-num-tasks-in-flight.The list also includes
memory-for-queries,geo-prefilter-planning-max-rows, andgeo-prefilter-planning-max-cost, which are not yet in QLever master but in its integration branchgeo-cell-integration(ad-freiburg/qlever#3783). That way, the integration branch can be used without a separate version ofqlever-control. Setting such a parameter on a server that does not know it fails with an error from the server, as for any other unknown parameter.The list only feeds the tab completion.
qlever settings key=valuealready passes any parameter to the server.