Skip to content

Adopt the analysis-workflow plugin; commit notebook outputs; zarr - #14

Merged
Marius1311 merged 4 commits into
mainfrom
feat/analysis-workflow
Oct 9, 2026
Merged

Marius1311 merged 4 commits into
mainfrom
feat/analysis-workflow

Conversation

@Marius1311

Copy link
Copy Markdown
Member

Changes

  • Agent conventions come from the analysis-workflow plugin. .claude/settings.json enables it (via the quadbio/claude-plugins marketplace), pixi.toml depends on its package (tag v0.1.0), and FilePaths.ROOT comes from its main_checkout() instead of a local resolver. AGENTS.md points at the plugin instead of restating conventions; README gains a short "Working with coding agents" section.
  • Notebook outputs are committed. The nbstripout filter, its install step and the CI check that rejected outputs are gone.
  • Zarr instead of h5ad in the examples; *.zarr ignored.
  • data/<dataset>/results/ is a notebook's own outputs, prefixed with the notebook's stem. data/ is ignored except its READMEs and placeholders (AGENTS.md already claimed this; only extensions were ignored).
  • Task-output rules in .gitignore: outputs/, logs/ and re-included results/ evidence.
  • REVIEW_GUIDE.md for GitHub review agents, generic part from the plugin.

The lock re-solve also floats a few packages (spatialdata 0.7.3 → 0.8.0, dask, numba, ome-zarr).

Next: converting the template to cruft, so repos can pull template updates with cruft update, as a separate PR.

🤖 Generated with Claude Code

Marius1311 and others added 3 commits October 8, 2026 16:13
- Enable the analysis-workflow plugin in .claude/settings.json and depend on its package;
  FilePaths.ROOT comes from its main_checkout().
- Notebook outputs are committed: drop the nbstripout filter, its install step and CI check.
- Examples write AnnData zarr; *.zarr ignored.
- data/<dataset>/results/ is a notebook's own outputs; data/ ignored except READMEs.
- Task-output rules in .gitignore; REVIEW_GUIDE.md (generic part from the plugin).
- AGENTS.md points at the plugin instead of restating conventions.

The lock file is regenerated once analysis-workflow v0.1.0 is tagged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@Marius1311 Marius1311 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good overall, some duplication left. Is the cruft setup in already?

Comment thread README.md Outdated

Humans work in notebooks; coding agents work in scripts, one task per session, git worktree and
`analysis/<topic>/.../<name>_vN/` directory. The conventions come from the
[analysis-workflow](https://github.com/quadbio/analysis-workflow) Claude Code plugin, which this

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it a plugin or a skill? I thought a plugin bundles several skills?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A plugin. A plugin is the installable unit and can bundle any number of skills, plus hooks, agents and MCP servers. This one bundles one skill (also called analysis-workflow) and the guard hooks. The Python package is separate: pixi installs it, not Claude. The README now says "plugin (a skill plus guard hooks)". a8ce86b

Comment thread README.md Outdated

## 🤖 Working with coding agents

Humans work in notebooks; coding agents work in scripts, one task per session, git worktree and

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're repeating this three times, here, in the skill, and in the agents.md file

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, removed from both the README and AGENTS.md. The skill owns it; AGENTS.md now only lists what the plugin owns and points there. a8ce86b

Comment thread README.md

---

## ☕ Daily Workflow

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider how much of this is needed, given what's in the skill now.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cut to the install step, which is the one thing the skill can't tell a human: it only loads after installation. Dropped the package sentence (pixi.toml shows it) and the REVIEW_GUIDE.md pointer (AGENTS.md has it). a8ce86b

The README keeps only the plugin install step and points at AGENTS.md; AGENTS.md names
what the plugin owns without restating it, and drops the worktree commands the skill and
its hook already own. The data layout now lives once for humans, in the README; the
dataset README and the sample notebook point there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Marius1311

Copy link
Copy Markdown
Member Author

Also in a8ce86b: the data/ layout had three copies in the template. It now lives once for humans, in the README; data/example_dataset/README.md and the sample notebook point there. The skill keeps its own copy for agents, since humans don't read the skill. AGENTS.md also drops the notebook-naming line (README owns it) and the worktree commands (the skill and its hook own them).

Cruft: not yet. It's planned as its own PR once this one merges, so its diff (moving everything under {{ cookiecutter.project_name }}/) stays separate from this content change.

@Marius1311
Marius1311 merged commit 2419048 into main Oct 9, 2026
2 checks passed
@Marius1311
Marius1311 deleted the feat/analysis-workflow branch October 9, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant