FROMLIST: PCI: qcom: Add D3cold support - #1038
Conversation
|
Merge Check Failed: No Change Task Found No associated change tasks found for CR 4569097 on any of the following entities: Entities:
CR: 4569097 Please ensure the CR has a change task associated with at least one of the entities for this branch. |
1 similar comment
|
Merge Check Failed: No Change Task Found No associated change tasks found for CR 4569097 on any of the following entities: Entities:
CR: 4569097 Please ensure the CR has a change task associated with at least one of the entities for this branch. |
|
Merge Check Failed: CR Not Eligible for Merge CR 4569097 is not eligible for merge. The parent software image for kernel.qli.2.0 is not development complete. Entity: Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations. |
4 similar comments
|
Merge Check Failed: CR Not Eligible for Merge CR 4569097 is not eligible for merge. The parent software image for kernel.qli.2.0 is not development complete. Entity: Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations. |
|
Merge Check Failed: CR Not Eligible for Merge CR 4569097 is not eligible for merge. The parent software image for kernel.qli.2.0 is not development complete. Entity: Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations. |
|
Merge Check Failed: CR Not Eligible for Merge CR 4569097 is not eligible for merge. The parent software image for kernel.qli.2.0 is not development complete. Entity: Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations. |
|
Merge Check Failed: CR Not Eligible for Merge CR 4569097 is not eligible for merge. The parent software image for kernel.qli.2.0 is not development complete. Entity: Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations. |
|
looks good to me |
Test Matrix
|
Shiraz Hashim (shashim-quic)
left a comment
There was a problem hiding this comment.
CRs-Fixed: 4569097
You can remove from commit log and only add CR details to PR description.
During resume from D3cold, set the PCIe controller to the maximum OPP before enabling the ICC paths and accessing DBI registers. Without this, qcom_pcie_icc_opp_update() may access DBI before OPP votes are restored, triggering NoC errors. The qli2.0 branch merged the D3cold patch (PR qualcomm-linux#461) before the 'Set max OPP before DBI access during resume' fix was applied, so the if (pcie->use_pm_opp) block was missing from the if (pcie->pci->suspended) branch in qcom_pcie_resume_noirq(). This commit brings qli2.0 in sync with upstream commit 2cc0e74. Link: https://lore.kernel.org/all/20260429-d3cold-v5-5-89e9735b9df6@oss.qualcomm.com/ Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com> Signed-off-by: Ziyue Zhang <ziyue.zhang@oss.qualcomm.com>
d6b9d8f to
12e3647
Compare
Hi Shriaz, this CRs-Fixed tag is removed |
Test Matrix
|
Test Matrix
|
ed3979f
into
qualcomm-linux:qcom-6.18.y
During resume from D3cold, set the PCIe controller to the maximum OPP
before enabling the ICC paths and accessing DBI registers. Without this,
qcom_pcie_icc_opp_update() may access DBI before OPP votes are restored,
triggering NoC errors.
The qli2.0 branch merged the D3cold patch (PR #461) before the
'Set max OPP before DBI access during resume' fix was applied, so the
if (pcie->use_pm_opp) block was missing from the if (pcie->pci->suspended)
branch in qcom_pcie_resume_noirq(). This commit brings qli2.0 in sync
with upstream commit 2cc0e74.
Signed-off-by: Krishna Chaitanya Chundru krishna.chundru@oss.qualcomm.com
Signed-off-by: Ziyue Zhang ziyue.zhang@oss.qualcomm.com
CRs-Fixed:4569097
Link: https://lore.kernel.org/all/20260429-d3cold-v5-5-89e9735b9df6@oss.qualcomm.com/