Skip to content

QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes for imx858, ov13b10 and imx577 - #1040

Open
sushilsingh045 wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
sushilsingh045:qli_2_0_lemans_draco_camera_sensor_dtsi
Open

QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes for imx858, ov13b10 and imx577#1040
sushilsingh045 wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
sushilsingh045:qli_2_0_lemans_draco_camera_sensor_dtsi

Conversation

@sushilsingh045

Copy link
Copy Markdown

Add camera sensor device tree support for the Draco-based Lemans EVK in QLI 2.0.
This change adds camera sensor nodes for the IMX858, OV13B10, and IMX577 sensors. These DTSI updates provide the required sensor entries and platform configuration needed for camera bring-up on the Draco-based Lemans EVK.
The change is added as part of QLI 2.0 camera sensor enablement.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

…, ov13b10 and imx577

 Add camera sensor device tree nodes for the Draco-based Lemans EVK to enable imx858, ov13b10 and imx577 sensors.

Signed-off-by: Sushil Pratap Singh <sussin@qti.qualcomm.com>
@sushilsingh045
sushilsingh045 force-pushed the qli_2_0_lemans_draco_camera_sensor_dtsi branch from 5c90fa5 to 235fba5 Compare September 9, 2026 04:20
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qlijarvis

Copy link
Copy Markdown

PR #1040 — validate-patch

PR: #1040

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1040 - QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes for imx858, ov13b10 and imx577
Upstream commit: N/A (vendor-only commit)
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: vendor-only commit
Body preserves rationale Clear description of camera sensor additions
Fixes tag present/correct N/A Not a fix commit
Authorship preserved Proper From: and Signed-off-by: present
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/lemans-draco-evk-camera-sensor.dtsi New file: 810 lines of camera sensor device tree nodes

Verdict

Merge as-is. This is a vendor-only commit with the correct QCLINUX: prefix, proper authorship, and clear commit message describing the addition of camera sensor device tree nodes for Lemans EVK.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Not checked — QCLINUX: vendor-only commit

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: d49c33864d06e9672dce57738be8851384578fcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1040 — checker-log-analyzer

PR: #1040
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34310678636

Checker Result Summary
Checker Result Summary
checkpatch 42 errors, 27 warnings, 1 check
dt-binding-check ⏭️ No binding changes
dtb-check ⏭️ No DTBs built (DTS-only change)
sparse-check ⏭️ No C/H files changed
check-uapi-headers ⏭️ No C/H files changed
check-patch-compliance QCLINUX: prefix not accepted
tag-check ⚠️ QCLINUX: is valid for qcom-6.18.y

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1040 - QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes for imx858, ov13b10 and imx577
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/34310678636
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch 42 errors, 27 warnings, 1 check
dt-binding-check ⏭️ No binding changes
dtb-check ⏭️ No DTBs built (DTS-only change)
sparse-check ⏭️ No C/H files changed
check-uapi-headers ⏭️ No C/H files changed
check-patch-compliance QCLINUX: prefix not accepted
tag-check ⚠️ QCLINUX: is valid for qcom-6.18.y

❌ checkpatch

Root cause: The new DTS file contains 42 indentation errors (spaces instead of tabs), 6 trailing whitespace errors, multiple undocumented DT compatible strings, 1 block comment alignment issue, and 1 commit message line length warning.

Failure details:

235fba5aeabd total: 42 errors, 27 warnings, 1 checks, 810 lines checked

ERROR: code indent should use tabs where possible
#74: FILE: arch/arm64/boot/dts/qcom/lemans-draco-evk-camera-sensor.dtsi:54:
+                     "CAMIF_RESET0",

ERROR: code indent should use tabs where possible
#75: FILE: arch/arm64/boot/dts/qcom/lemans-draco-evk-camera-sensor.dtsi:55:
+                     "CAM_CUSTOM0";

ERROR: trailing whitespace
#190: FILE: arch/arm64/boot/dts/qcom/lemans-draco-evk-camera-sensor.dtsi:170:
+<trailing whitespace>

WARNING: Block comments should align the * on each line
#24: FILE: arch/arm64/boot/dts/qcom/lemans-draco-evk-camera-sensor.dtsi:4:
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.

WARNING: DT compatible string "qcom,cam-res-mgr" appears un-documented
WARNING: DT compatible string "qcom,actuator" appears un-documented
WARNING: DT compatible string "qcom,eeprom" appears un-documented
WARNING: DT compatible string "qcom,cam-sensor" appears un-documented

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)

Fix:

  1. Indentation errors (42 errors): Replace leading spaces with tabs in gpio-req-tbl-label arrays:

    # Lines 54-55, 94-95, 128-129, 168-169, 204, 253-254, 293-294, 327-328, 367-368, etc.
    # Replace spaces with tabs for continuation lines
    sed -i 's/^                     /\t\t\t\t     /' arch/arm64/boot/dts/qcom/lemans-draco-evk-camera-sensor.dtsi
  2. Trailing whitespace (6 errors): Remove trailing whitespace:

    sed -i 's/[[:space:]]*$//' arch/arm64/boot/dts/qcom/lemans-draco-evk-camera-sensor.dtsi
  3. Block comment alignment: Fix the copyright block comment:

    /*
    - * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
    + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
    */
  4. Undocumented DT strings (27 warnings): These are vendor-specific Qualcomm camera subsystem compatible strings (qcom,cam-res-mgr, qcom,actuator, qcom,eeprom, qcom,cam-sensor). These are not blockers — they are used throughout the Qualcomm tree and do not have upstream bindings. Document them if submitting upstream, but acceptable for vendor tree.

  5. Commit message line length: The commit body line is slightly over 75 chars. Wrap it:

    Add camera sensor device tree nodes for the Draco-based Lemans EVK to
    enable imx858, ov13b10 and imx577 sensors.
    

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES \
  --git b5d890825bc2..235fba5aeabd

❌ check-patch-compliance

Root cause: The commit subject uses the QCLINUX: prefix, which is not in the checker's allowed list (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes for imx858, ov13b10 and imx577
Commit summary does not start with a required prefix

Analysis: This is a known limitation of the check-patch-compliance checker. The QCLINUX: prefix is a valid vendor-internal prefix used for Qualcomm-specific changes that have no upstream equivalent. The checker only accepts upstream-linkable prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Fix: This is not a blocker for vendor branches like qcom-6.18.y. The QCLINUX: prefix is correct for this vendor-only camera sensor addition. The checker will always fail for QCLINUX: commits — this is expected behavior.

Alternative (if upstream submission is planned): If this change will be posted upstream, change the prefix to FROMLIST: and add a Link: trailer pointing to the lore.kernel.org URL once posted.


⚠️ tag-check (manual check for qcom-6.18.y)

Analysis: The target branch is qcom-6.18.y, which is not qcom-next or qcom-next-staging. Therefore, every commit must start with a valid prefix tag.

Commit subject: QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes for imx858, ov13b10 and imx577

Verdict:PASS — The commit subject starts with QCLINUX:, which is a valid prefix for vendor-only changes.

Note: While check-patch-compliance rejects QCLINUX:, the tag-check accepts it as a valid prefix for branches other than qcom-next/qcom-next-staging. This is a known discrepancy between the two checks.


Verdict

Fix 3 blockers before merge:

  1. Indentation errors (42): Replace spaces with tabs in gpio-req-tbl-label continuation lines
  2. Trailing whitespace (6): Remove trailing whitespace from 6 lines
  3. Block comment alignment (1): Align the * in the copyright block comment

Optional improvements:

  • Wrap the commit body line to stay under 75 chars
  • The 27 undocumented DT string warnings are not blockers — these are vendor-specific camera subsystem compatible strings used throughout the Qualcomm tree

Not blockers:

  • check-patch-compliance failure on QCLINUX: prefix is expected for vendor-only commits
  • QCLINUX: is a valid prefix for qcom-6.18.y branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants