[RISCV] Fix post-ALIGN JAL rollback to use post-ALIGN layout - #1689
Merged
Conversation
Shankar Easwaran (quic-seaswara)
force-pushed
the
jal_unroll
branch
from
August 12, 2026 01:04
ae9882f to
0ba6b33
Compare
The ALIGN pass commits byte deletions inline (via deleteInstruction), shrinking fragments and shifting VMAs, but createProgramHdrs() is not called again until the next outer-loop iteration. So the range check (isInt<21>(X)) saw pre-ALIGN VMAs and missed calls that were actually out of range after the ALIGN deletions. Fixes #1688. Signed-off-by: Shankar Easwaran <seaswara@qti.qualcomm.com>
Shankar Easwaran (quic-seaswara)
force-pushed
the
jal_unroll
branch
from
August 12, 2026 01:25
0ba6b33 to
ba1cc90
Compare
Shankar Easwaran (quic-seaswara)
added
the
zephyr-check
Shankar Easwaran (quic-seaswara)
merged commit Aug 12, 2026
5fd859e
into
main
14 of 15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ALIGN pass commits byte deletions inline (via
deleteInstruction), shrinking fragments and shifting VMAs, but createProgramHdrs() is not called again until the next outer-loop iteration. So the range check (isInt<21>(X)) saw pre-ALIGN VMAs and missed calls that were actually out of range after the ALIGN deletions.
Fixes #1688