refactor: platform-neutral API cleanup - rename Android-specific symbols and remove vendor path hardcoding by quic-vkatoch · Pull Request #154 · qualcomm/fastrpc

Vinayak Katoch (quic-vkatoch) · 2025-03-18T11:22:05Z

Remove Android-specific naming, dead code, and hardcoded paths from the fastrpc library to make it platform-neutral.

Rename listener_android.h/c to listener.h/c and update all symbol references throughout the codebase.
Replace fastrpc_android.h/c with fastrpc_platform.h/c exposing a neutral two-function API; move Android internals to file-static scope and add an LE stub in the same file.
Fix off-by-one OOB bounds check in fastrpc_get_property_int/string (> to >=) for the FASTRPC_BUILD_TYPE property key.
Remove hardcoded /vendor/dsp/ fallback paths from open_shell(); these are already covered by DEFAULT_DSP_SEARCH_PATHS at build time.
Fix header guard FASTRPC_ANDROID_USER_H to FASTRPC_APPS_USER_H.
Remove dead #if 0 blocks, stale comments, and Android-specific arrays that are no longer reachable after the platform layer refactor.

Ekansh Gupta (ekanshibu) · 2025-04-25T05:10:54Z

Please check if you can break the change into multiple commits instead of a single commit.

github-actions · 2025-07-15T02:15:16Z

This pull request has been marked as stale due to 60 days of inactivity. To prevent automatic closure in 10 days, remove the stale label or add a comment. You can reopen a closed pull request at any time.

Ekansh Gupta (ekanshibu) · 2025-08-07T17:46:09Z

Vinayak Katoch (@quic-vkatoch), can you please rebase this PR?

Vinayak Katoch (quic-vkatoch) · 2025-08-12T11:27:43Z

Vinayak Katoch (@quic-vkatoch), can you please rebase this PR?

Done

Vinayak Katoch (quic-vkatoch) · 2026-01-14T06:31:55Z

Dmitry Baryshkov (@lumag), could you please review this PR?

Vinayak Katoch (quic-vkatoch) · 2026-02-02T10:54:04Z

Dmitry Baryshkov (@lumag), I have addressed the comments. Could you please review it again?

github-actions · 2026-03-11T02:16:18Z

qualcomm/fastrpc.triage This pull request has been marked as stale due to 30 days of inactivity.

Rename listener_android.h/c to listener.h/c and update all symbol references (listener_android_* to listener_*), PL_DEFINE/PL_DEP/PL_ENTRY entries, and Makefiles. Signed-off-by: Vinayak Katoch <vinayak.katoch@oss.qualcomm.com>

Replace fastrpc_android.h/c with fastrpc_platform.h/c exposing two neutral functions: fastrpc_platform_get_property_int/string. Android internals (property name table, property_get stubs) moved to file-static scope; LE stub added in the same file under #else. Update fastrpc_apps_user.c to include the new header unconditionally, remove Android-specific arrays and stubs, fix an off-by-one OOB bounds check (> to >=) in the property key range check, and update Makefiles. Signed-off-by: Vinayak Katoch <vinayak.katoch@oss.qualcomm.com>

Remove VENDOR_DSP_LOCATION and VENDOR_DOM_LOCATION defines and the vendor path fallback logic in open_shell(). Inline the DSP_LIBS_LOCATION search directly into open_shell() removing the try_open_shell_file() helper which existed solely to abstract the vendor fallbacks. The base-name retry (fastrpc_shell without domain suffix) is preserved. Also update two vendor-specific comments in apps_std_imp.c and remove a dead #if 0 block. Signed-off-by: Vinayak Katoch <vinayak.katoch@oss.qualcomm.com>

Remove stale AEE_EINVHANDLE comment, fix header guard FASTRPC_ANDROID_USER_H to FASTRPC_APPS_USER_H, remove dead Android TODO include block in fastrpc_trace.h, remove #if 0 log priority function in adspmsgd_printf.c, fix "buuid" typo in fastrpc_log.c, and collapse 3-way PROPERTY_VALUE_MAX #ifdef to a single #define in fastrpc_mem.c. Signed-off-by: Vinayak Katoch <vinayak.katoch@oss.qualcomm.com>

Ekansh Gupta (ekanshibu) reviewed Apr 7, 2025

View reviewed changes

Comment thread src/fastrpc_apps_user.c

Comment thread src/adspmsgd.c Outdated

Dmitry Baryshkov (lumag) reviewed Apr 22, 2025

View reviewed changes

Comment thread src/fastrpc_apps_user.c Outdated

Vinayak Katoch (quic-vkatoch) force-pushed the code-cleanup branch from 5ad182f to e92d2c8 Compare April 24, 2025 04:00

Dmitry Baryshkov (lumag) reviewed Apr 24, 2025

View reviewed changes

Comment thread src/fastrpc_apps_user.c Outdated

Vinayak Katoch (quic-vkatoch) force-pushed the code-cleanup branch from e92d2c8 to 66cba44 Compare April 25, 2025 08:33

Dmitry Baryshkov (lumag) reviewed Apr 25, 2025

View reviewed changes

Comment thread src/fastrpc_log.c Outdated

github-actions Bot added the Stale label Jul 15, 2025

Vinayak Katoch (quic-vkatoch) force-pushed the code-cleanup branch 3 times, most recently from 0ffa6c4 to f7d23d7 Compare August 12, 2025 10:48

Ekansh Gupta (ekanshibu) removed the Stale label Aug 12, 2025

Vinayak Katoch (quic-vkatoch) force-pushed the code-cleanup branch from f7d23d7 to 4e34aac Compare August 12, 2025 11:21

Ekansh Gupta (ekanshibu) reviewed Aug 24, 2025

View reviewed changes

Comment thread src/fastrpc_log.c

Ekansh Gupta (ekanshibu) requested changes Aug 24, 2025

View reviewed changes

Comment thread inc/AEEStdErr.h

Vinayak Katoch (quic-vkatoch) force-pushed the code-cleanup branch from 4e34aac to 44fd420 Compare August 25, 2025 06:26

Vinayak Katoch (quic-vkatoch) requested a review from Ekansh Gupta (ekanshibu) August 25, 2025 06:30

Ekansh Gupta (ekanshibu) previously approved these changes Sep 1, 2025

View reviewed changes

Ekansh Gupta (ekanshibu) enabled auto-merge September 1, 2025 04:27

auto-merge was automatically disabled October 13, 2025 16:56
Head branch was pushed to by a user without write access

Vinayak Katoch (quic-vkatoch) dismissed Ekansh Gupta (ekanshibu)’s stale review via ef69f29 October 13, 2025 16:56

Vinayak Katoch (quic-vkatoch) force-pushed the code-cleanup branch 2 times, most recently from ef69f29 to 040ef4c Compare October 13, 2025 17:14

Vinayak Katoch (quic-vkatoch) requested review from Ekansh Gupta (ekanshibu) and Dmitry Baryshkov (lumag) October 14, 2025 06:12

Dmitry Baryshkov (lumag) suggested changes Oct 14, 2025

View reviewed changes

Comment thread inc/apps_std_internal.h

Comment thread inc/fastrpc_trace.h

Comment thread src/pl_list.c

Comment thread src/Makefile.am

Comment thread src/fastrpc_apps_user.c

Comment thread src/fastrpc_apps_user.c

Comment thread src/fastrpc_log.c

Vinayak Katoch (quic-vkatoch) force-pushed the code-cleanup branch from 040ef4c to e26a068 Compare October 22, 2025 17:48

Vinayak Katoch (quic-vkatoch) force-pushed the code-cleanup branch from 056c191 to 9d4d996 Compare January 13, 2026 17:32

Bharath Kumar V (quic-bkumar) previously approved these changes Jan 14, 2026

View reviewed changes

Ekansh Gupta (ekanshibu) requested changes Jan 14, 2026

View reviewed changes

Comment thread src/fastrpc_android.c Outdated

Comment thread inc/fastrpc_android.h Outdated

Dmitry Baryshkov (lumag) suggested changes Jan 14, 2026

View reviewed changes

Comment thread inc/fastrpc_apps_user.h Outdated

Comment thread inc/fastrpc_android.h Outdated

Comment thread src/fastrpc_android.c Outdated

Vinayak Katoch (quic-vkatoch) dismissed Bharath Kumar V (quic-bkumar)’s stale review via 0dc0c36 January 18, 2026 16:27

Vinayak Katoch (quic-vkatoch) force-pushed the code-cleanup branch from 9d4d996 to 0dc0c36 Compare January 18, 2026 16:27

Vinayak Katoch (quic-vkatoch) requested review from Ekansh Gupta (ekanshibu) and Dmitry Baryshkov (lumag) January 18, 2026 16:34

Vinayak Katoch (quic-vkatoch) force-pushed the code-cleanup branch from 0dc0c36 to e4aee33 Compare January 19, 2026 11:13

Vinayak Katoch (quic-vkatoch) requested a review from Bharath Kumar V (quic-bkumar) January 21, 2026 05:57

Bharath Kumar V (quic-bkumar) reviewed Feb 2, 2026

View reviewed changes

Comment thread inc/fastrpc_android.h Outdated

Chenna Kesava Raju (Chennak-quic) previously approved these changes Feb 3, 2026

View reviewed changes

github-actions Bot added the Stale label Mar 11, 2026

Vinayak Katoch (quic-vkatoch) dismissed Chenna Kesava Raju (Chennak-quic)’s stale review via e523f4e August 11, 2026 11:26

Vinayak Katoch (quic-vkatoch) force-pushed the code-cleanup branch from e4aee33 to e523f4e Compare August 11, 2026 11:26

Vinayak Katoch (quic-vkatoch) changed the title ~~Refactor: Generalize Code by Moving Vendor and Android-Specific Elements~~ refactor: replace Android-specific naming with platform-neutral API Aug 11, 2026

Vinayak Katoch (quic-vkatoch) force-pushed the code-cleanup branch from e523f4e to 64820e8 Compare August 11, 2026 11:30

Vinayak Katoch (quic-vkatoch) added 4 commits August 11, 2026 17:03

refactor: rename listener_android to listener

8260b42

Rename listener_android.h/c to listener.h/c and update all symbol references (listener_android_* to listener_*), PL_DEFINE/PL_DEP/PL_ENTRY entries, and Makefiles. Signed-off-by: Vinayak Katoch <vinayak.katoch@oss.qualcomm.com>

Vinayak Katoch (quic-vkatoch) force-pushed the code-cleanup branch from 64820e8 to e30653b Compare August 11, 2026 12:46

Vinayak Katoch (quic-vkatoch) requested review from Chenna Kesava Raju (Chennak-quic) and Bharath Kumar V (quic-bkumar) August 11, 2026 12:46

Vinayak Katoch (quic-vkatoch) changed the title ~~refactor: replace Android-specific naming with platform-neutral API~~ refactor: platform-neutral API cleanup — rename Android-specific symbols and remove vendor path hardcoding Aug 11, 2026

Vinayak Katoch (quic-vkatoch) changed the title ~~refactor: platform-neutral API cleanup — rename Android-specific symbols and remove vendor path hardcoding~~ refactor: platform-neutral API cleanup - rename Android-specific symbols and remove vendor path hardcoding Aug 11, 2026

Vinayak Katoch (quic-vkatoch) removed the Stale label Aug 11, 2026

Uh oh!

Conversation

Vinayak Katoch (quic-vkatoch) commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ekansh Gupta (ekanshibu) commented Apr 25, 2025

Uh oh!

Uh oh!

github-actions Bot commented Jul 15, 2025

Uh oh!

Ekansh Gupta (ekanshibu) commented Aug 7, 2025

Uh oh!

Vinayak Katoch (quic-vkatoch) commented Aug 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Vinayak Katoch (quic-vkatoch) commented Jan 14, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Vinayak Katoch (quic-vkatoch) commented Feb 2, 2026

Uh oh!

Uh oh!

github-actions Bot commented Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Vinayak Katoch (quic-vkatoch) commented Mar 18, 2025 •

edited

Loading