Move initiator TLS and dialer setup into session factory#769
Open
codernull wants to merge 1 commit into
Open
Conversation
codernull
force-pushed
the
move-initiator-tls-dialer-to-session-factory
branch
5 times, most recently
from
July 16, 2026 06:04
698b92e to
9f2a3d3
Compare
Complete the long-standing TODO by configuring TLS and dialer in sessionFactory, and avoid mutating shared tls.Config ServerName across reconnects.
codernull
force-pushed
the
move-initiator-tls-dialer-to-session-factory
branch
from
July 16, 2026 09:50
9f2a3d3 to
0736b21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Initiator.Start()by loading TLS and dialer configuration insessionFactoryalongside other initiator settings.tlsConfiganddialeron the session so connection handling no longer depends on config loaded at start time.tls.Config.ServerNameacross reconnect attempts by deriving ServerName per address viatlsConfigForAddress.