Skip to content

fix(datetime): accept an eight-digit subsecond java date format token #6804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trinity-1686a merged 2 commits into from
Sep 18, 2026
+17 −5
Merged

fix(datetime): accept an eight-digit subsecond java date format token #6804

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1171a4e
fix(datetime): accept an eight-digit subsecond java date format token
rawsun007 Sep 16, 2026
362f85f
Merge branch 'main' into fix/subsecond-eight-digits
trinity-1686a Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions quickwit/quickwit-datetime/src/java_date_time_format.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,9 @@ const JAVA_DATE_FORMAT_TOKENS: &[&str] = &[
"yyyy",
"xxxx",
"SSSSSSSSS", // For nanoseconds
"SSSSSSS", // For microseconds
"SSSSSS", // For fractional seconds up to six digits
"SSSSSSSS",
"SSSSSSS", // For microseconds
"SSSSSS", // For fractional seconds up to six digits
"SSSSS",
"SSSS",
"SSS",
Expand Down Expand Up @@ -238,9 +239,8 @@ fn match_java_date_format_token(
"HH" | "H" => build_hour_item(token),
"mm" | "m" => build_minute_item(token),
"ss" | "s" => build_second_item(token),
"SSSSSSSSS" | "SSSSSSS" | "SSSSSS" | "SSSSS" | "SSSS" | "SSS" | "SS" | "S" => {
build_fraction_of_second_item(token)
}
"SSSSSSSSS" | "SSSSSSSS" | "SSSSSSS" | "SSSSSS" | "SSSSS" | "SSSS" | "SSS"
| "SS" | "S" => build_fraction_of_second_item(token),
"Z" => build_zone_offset(token),
"ww" | "w[w]" | "w" => build_week_of_year_item(token),
"e" => build_day_of_week_item(token),
Expand Down Expand Up @@ -485,6 +485,18 @@ mod tests {
assert_eq!(datetime, expected_datetime);
}

#[test]
fn test_parse_java_datetime_format_every_subsecond_width() {
for num_digits in 1..=9 {
let format = format!("yyyy-MM-dd HH:mm:ss.{}", "S".repeat(num_digits));
test_parse_java_datetime_aux(
&format,
"2021-01-01 11:00:03.123456789",
datetime!(2021-01-01 11:00:03.123456789 UTC),
);
}
}

#[test]
fn test_parse_java_datetime_format() {
test_parse_java_datetime_aux("yyyyMMdd", "20210101", datetime!(2021-01-01 00:00:00 UTC));
Expand Down
Loading