fix(ui): Add bottom margin to voucher message dialog - #461
Open
Jack251970 wants to merge 1 commit into
Open
Conversation
Jack251970
changed the title
There was a problem hiding this comment.
🟢 Approval recommended
Single, low-risk Tailwind class adjustment consistent with how DialogFooter is overridden elsewhere in the app.
Pull request overview
This PR adjusts the frontend account reset voucher dialog layout by neutralizing the default negative margins applied by the shared DialogFooter, so the footer spacing/padding renders as intended.
Changes:
- Update
DialogFooterclass overrides to cancel the component’s default-mx-4 -mb-4margins (viamx-0 mb-0). - Keep the custom footer styling (border/background/padding) intact while fixing the layout spacing.
File summaries
| File | Description |
|---|---|
apps/src/components/account-reset-credit-control.tsx |
Overrides DialogFooter margins to prevent the default negative margins from affecting the voucher/reset dialog footer layout. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Jack251970
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更摘要
改动范围
主要文件
验证
pnpm -C apps run testpnpm -C apps run buildpnpm -C apps run test:uicargo test --workspace已执行的实际验证：
未执行的验证与原因：
风险与影响面
备注