Skip to content

Fix translations on R devel #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lionel- merged 1 commit into from
Jun 15, 2026
Merged

Fix translations on R devel #290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions tests/testthat/test-language.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
test_that("can temporarily change language", {
# Skipped on CRAN because R's translations change over time, which
# breaks the exact error message matches below
skip_on_cran()
skip_if_not(has_nls())

# `with_language()` doesn't work when locale is set to C. At the
Expand All @@ -9,13 +12,16 @@ test_that("can temporarily change language", {

expect_error(with_language("en", mean[[1]]), "not subsettable")
expect_error(with_language("fr", mean[[1]]), "non indi\u00e7able")
expect_error(with_language("es", mean[[1]]), "no es subconjunto")
# R-devel changed the Spanish translation from "no es subconjunto" to
# "no se puede seleccionar elementos", so match either form
expect_error(with_language("es", mean[[1]]), "no es subconjunto|no se puede seleccionar")

# Is correctly reset (#213)
expect_error(mean[[1]], "not subsettable")
})

test_that("can use use either _ or -", {
skip_on_cran()
skip_if_not(has_nls())
skip_if_c_locale()

Expand All @@ -24,13 +30,14 @@ test_that("can use use either _ or -", {
})

test_that("can temporarily change language after triggering error", {
skip_on_cran()
skip_if_not(has_nls())
skip_if_c_locale()

local_language("fr")
try(mean[[1]], silent = TRUE) # trigger possible caching

expect_error(with_language("es", mean[[1]]), "no es subconjunto")
expect_error(with_language("es", mean[[1]]), "no es subconjunto|no se puede seleccionar")
})

test_that("warns if LC_ALL=C", {
Expand Down
Loading