Repository navigation
fix(web): News calendar classes clashed with the Stats activity strip; quieter dateline rule - #223
Merged
Merged
Conversation
… strip; a quieter dateline rule The month calendar beside the news (M14.11) was styled as .cal / .cal-grid, the names the Stats view's activity strip (components/charts.tsx) already owns, so that strip got the calendar's panel border and a table layout and rendered as an empty box. check:classes passes on a className that exists anywhere, which is exactly how a collision slips through. The month calendar is .mcal-* now; the strip is untouched. The rule under a dateline was a 2px bar in the full foreground colour, which glares on a dark ground; it is a 1px line at 35% of it now. Verified on a copy of the live database through a scratch daemon in headless Chrome: the strip shows 53 columns with 71 lit days, the News calendar lays its seven columns at 29px each. typecheck, lint, 1105 tests, build:web, check:classes. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things seen on 0.18.1's dark dashboard.
.cal/.cal-grid, the class names the Stats view's activity strip incomponents/charts.tsxalready owned, so the strip inherited the calendar's panel border, padding anddisplay: table.check:classespasses on any className that exists somewhere, which is how the collision got through. The month calendar is.mcal-*now; the strip's rules are untouched.Verified on a copy of the live database through a scratch daemon in headless Chrome: the strip shows 53 columns with 71 lit days again, the News calendar lays its seven columns at 29px each, the rule computes to 1px at 35% alpha.
typecheck · lint · test (1105 pass) · build:web · check:classes
🤖 Generated with Claude Code