Skip to content

perf(sys): Copy callstack block at once - #745

Merged
rabbitstack merged 1 commit into
masterfrom
callstack-block-copy
Oct 27, 2026
Merged

rabbitstack merged 1 commit into
masterfrom
callstack-block-copy

Conversation

@rabbitstack

Copy link
Copy Markdown
Owner

What is the purpose of this PR / why it is needed?

ReadCallstackInto and Callstack decoded frames one at a time through ReadUint64. The return addresses are consecutive little-endian uint64 values, which is the in-memory layout of va.Address, so copy the whole block at once.

What type of change does this PR introduce?


Uncomment one or more /kind <> lines:

/kind feature (non-breaking change which adds functionality)

/kind bug-fix (non-breaking change which fixes an issue)

/kind refactor (non-breaking change that restructures the code, while not changing the original functionality)

/kind breaking (fix or feature that would cause existing functionality to not work as expected

/kind cleanup

/kind improvement

/kind design

/kind documentation

/kind other (change that doesn't pertain to any of the above categories)

Any specific area of the project related to this PR?


Uncomment one or more /area <> lines:

/area instrumentation

/area telemetry

/area rule-engine

/area filters

/area yara

/area event

/area captures

/area alertsenders

/area outputs

/area rules

/area filaments

/area config

/area cli

/area tests

/area ci

/area build

/area docs

/area deps

/area evasion

/area other

Special notes for the reviewer


Does this PR introduce a user-facing change?


ReadCallstackInto and Callstack decoded frames one at a time through ReadUint64. The
return addresses are consecutive little-endian uint64 values, which is
the in-memory layout of va.Address, so copy the whole block at once.
@rabbitstack
rabbitstack merged commit 1fd558d into master Oct 27, 2026
10 of 11 checks passed
@rabbitstack
rabbitstack deleted the callstack-block-copy branch October 27, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant