feat: unified install script with secret management and rotation - #1641
Draft
rackerchris wants to merge 1 commit into
Draft
feat: unified install script with secret management and rotation#1641rackerchris wants to merge 1 commit into
rackerchris wants to merge 1 commit into
Conversation
rackerchris
changed the title
rackerchris
force-pushed
the
unified-install-script
branch
from
June 24, 2026 20:38
a878d8b to
5582f6c
Compare
the2hill
reviewed
Jun 26, 2026
the2hill
approved these changes
Jun 26, 2026
the2hill
left a comment
the2hill
left a comment
Contributor
There was a problem hiding this comment.
This LGTM minus the fluentbit parts.. but that can be cleaned up later if anything.
rackerchris
force-pushed
the
unified-install-script
branch
7 times, most recently
from
July 9, 2026 16:44
6abec74 to
33573c4
Compare
rackerchris
force-pushed
the
unified-install-script
branch
from
July 10, 2026 13:51
33573c4 to
37716eb
Compare
rackerchris
marked this pull request as draft
July 17, 2026 14:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bin/install.sh — Unified service install framework
48 individual install-*.sh scripts → single bin/install.sh with per-service YAML.
Deleted: 48 bin/install-*.sh (~8,500 lines, 95% duplicate code), bin/create-secrets.sh, bin/install-service-template.sh
Added: bin/install.sh, bin/helpers.sh, 49 bin/services/*.yaml
CLI
install.sh --service nova # basic install
install.sh --service nova --wait --timeout 30m # helm flags passed through
install.sh --rotate-keys --service nova # rotate secrets, then install
install.sh --check-secrets --service nova # fail if secrets missing
All remaining --* flags go straight to helm. No special-cased wrapper.
Secrets: k8s-only
Check k8s → generate & create if missing. --rotate-keys rotates only -/-
Configs: per-service, minimal
Each YAML declares only its unique secrets. Common defaults (namespace, helm repo, kustomize overlay) come from openstack-common.yaml or monitoring-common.yaml.