feat: add idle Azure VPN Gateway detection - #23
Merged
Merged
Conversation
raphgm
approved these changes
Sep 22, 2026
raphgm
left a comment
Owner
There was a problem hiding this comment.
Verified: pulled the branch, ran all 50 existing tests locally, all pass (matches your claim). Independently confirmed the live pricing filter against the Retail Prices API for a real SKU (VpnGw1, eastus -> $0.19/hr, correct). Good detail on the az.cmd/az cross-platform handling for Windows — most existing checks in this repo don't bother with that. Closes #12 cleanly. Thanks for following up on the questions in the issue thread first before building this.
Contributor
Author
|
Thanks for reviewing and independently validating the implementation. I appreciate the feedback and the opportunity to contribute to the project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for detecting idle Azure VPN Gateways based on Azure Monitor bandwidth metrics.
Changes
azure.idle_vpn_gatewaysource.AverageBandwidthmetric using hourly intervals over the configured lookback period.Validation
AverageBandwidthmetric.Closes #12