Skip to content

RDKEMW-26909 : Align CI workflows with heatmap standard - #123

Merged
swethasukumarr merged 4 commits into
developfrom
feature/RDKEMW-26909
Oct 14, 2026
Merged

swethasukumarr merged 4 commits into
developfrom
feature/RDKEMW-26909

Conversation

@swethasukumarr

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI balanced review requested due to automatic review settings October 14, 2026 16:54
Comment thread .github/workflows/L1-tests.yml Fixed
Comment thread .github/workflows/L1-tests.yml Fixed
Comment thread .github/workflows/L2-tests.yml Fixed
Comment thread .github/workflows/L2-tests.yml Fixed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The coding guidelines reference an unavailable authoritative specification and incorrectly identify the active CI mock-version pin.

4 open findings
What changed in this PR

Aligns CI workflows with the heatmap standard by extracting reusable test workflows and updating automation conventions.

Changes:

  • Splits L1 and L2 tests into reusable workflows.
  • Updates release, synchronization, coverage, and transport configuration.
  • Removes the temporary TextToSpeech test exclusion and expands coding guidance.
File Description
README.md Removes the temporary exclusion notice.
docs/​ci/​text-to-speech-component-test-exclusion.md Deletes obsolete exclusion documentation.
.transport.version Updates the transport dependency.
.github/​workflows/​tests-trigger.yml Delegates tests to reusable L1/L2 workflows.
.github/​workflows/​sync-develop-to-main.yml Renames the automation token.
.github/​workflows/​release.yml Aligns release branches and token usage.
.github/​workflows/​L2-tests.yml Adds reusable component and API testing.
.github/​workflows/​L1-tests.yml Adds reusable unit testing and coverage.
.github/​scripts/​compare_coverage_test.py Updates workflow terminology.
.github/​instructions/​coding-guidelines.instructions.md Expands repository development guidance.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/instructions/coding-guidelines.instructions.md Outdated
Comment thread .github/instructions/coding-guidelines.instructions.md Outdated
Comment thread .github/instructions/coding-guidelines.instructions.md Outdated
Comment thread .github/instructions/coding-guidelines.instructions.md Outdated
Copilot AI balanced review requested due to automatic review settings October 14, 2026 17:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The coding guidance introduces an unavailable authoritative specification and contains inaccurate verification notes.

1 open finding
4 resolved since last review
Previously missed (2)

In code that hasn't changed since last review

Low severity Remove stale VERIFY marker for existing repository files

.github/​instructions/​coding-guidelines.instructions.md:516

This verification item is already resolvable from the repository: the script maps to .github/mock-firebolt/config--legacy.json and docs/openrpc/the-spec/firebolt-open-rpc--legacy.json, and both files exist; the app fixture is deliberately ignored. Leaving this marked [VERIFY] contradicts the marker's definition and gives readers stale guidance.

Low severity Enable pipefail in the Docker subprocess

.github/​instructions/​coding-guidelines.instructions.md:673

lint.sh itself already starts with set -euo pipefail; the missing pipefail is specifically inside its Docker bash -lc "set -e && ... | ..." subprocess. Describing the script as having no pipefail obscures where the fix must be applied.

🧠 Review effort: Balanced

Comment thread .github/instructions/coding-guidelines.instructions.md Outdated
Copilot AI balanced review requested due to automatic review settings October 14, 2026 17:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Legacy CI now runs TextToSpeech event tests against incompatible legacy event names.

1 open finding
1 resolved since last review

🧠 Review effort: Balanced

Comment thread .github/workflows/L2-tests.yml
@swethasukumarr
swethasukumarr merged commit cc866fa into develop Oct 14, 2026
16 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 14, 2026
@swethasukumarr
swethasukumarr deleted the feature/RDKEMW-26909 branch October 14, 2026 18:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants