[codex] Fix keyboard event detection to use logical keys#1080
Draft
wanxiankai wants to merge 1 commit into
Draft
[codex] Fix keyboard event detection to use logical keys#1080wanxiankai wants to merge 1 commit into
wanxiankai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Checklist:
Fixes #1030.
What changed
KeyboardEvent.key, which represents the logical key value.keyCodefallback for older React/IE environments.keyand add a regression test for a physical Escape code that represents a different logical key.Why
KeyboardEvent.codeidentifies the physical key location. Some input methods can therefore emitcode: "Escape"whilekeyis a non-Escape value such as"Process". The previous check treated that event as Escape and closed the modal unexpectedly while the user was inserting text or emoji.Validation
should not close when Escape code represents another logical keynpm run lintgit diff --check