Repository navigation
Replace sebastian/lines-of-code with custom code - #150
Merged
Merged
Conversation
TomasVotruba
force-pushed
the
remove-lines-of-code
branch
from
October 1, 2026 12:37
4b7e459 to
433e27a
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the
sebastian/lines-of-coderuntime dependency (PHP 8.3 floor) in favor of a small in-houseCommentLineCountingNodeVisitor.Only
linesOfCode()andcommentLinesOfCode()were used. Total lines already came fromresolveInitLinesOfCode(); the comment line count is now gathered in the same AST traversal asStructureNodeVisitor(one pass instead of two), replicating the original dedupe-by-token-position logic.Behavior covered by the existing
AnalyserTest(comment and line assertions unchanged).One step toward running swiss-knife on PHP 7.4-8.5.