Skip to content

OCPBUGS-104041: Use patched x/net fork v0.50.0-sec.4 - #757

Closed
prabhapa wants to merge 1 commit into
redhat-cne:release-4.21from
prabhapa:cve/4.21/OCPBUGS-104041
Closed

prabhapa wants to merge 1 commit into
redhat-cne:release-4.21from
prabhapa:cve/4.21/OCPBUGS-104041

Conversation

@prabhapa

Copy link
Copy Markdown

Summary

This PR replaces golang.org/x/net with github.com/openshift-sustaining/net@v0.50.0-sec.4.

Rationale

CVE-2026-33814, a Go HTTP/2 denial of service caused by a malformed SETTINGS_MAX_FRAME_SIZE frame, is fixed upstream in golang.org/x/net v0.53.0, which requires Go 1.25. The release-4.21 branch is built with Go 1.24 and cannot consume that upstream release. The v0.50.0-sec.4 sustaining fork carries the compatible backport for this Go version.

Source

Jira coverage

This shared source change addresses:

  • OCPBUGS-104041 — openshift4/ose-cloud-event-proxy-rhel9

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: be6b91f9-c618-48eb-8e13-8914b11a1a7a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prabhapa
Once this PR has been reviewed and has the lgtm label, please assign jzding for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot

Copy link
Copy Markdown

@prabhapa: This pull request references Jira Issue OCPBUGS-104041, which is invalid:

  • expected dependent Jira Issue OCPBUGS-101884 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

This PR replaces golang.org/x/net with github.com/openshift-sustaining/net@v0.50.0-sec.4.

Rationale

CVE-2026-33814, a Go HTTP/2 denial of service caused by a malformed SETTINGS_MAX_FRAME_SIZE frame, is fixed upstream in golang.org/x/net v0.53.0, which requires Go 1.25. The release-4.21 branch is built with Go 1.24 and cannot consume that upstream release. The v0.50.0-sec.4 sustaining fork carries the compatible backport for this Go version.

Source

Jira coverage

This shared source change addresses:

  • OCPBUGS-104041 — openshift4/ose-cloud-event-proxy-rhel9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Hi @prabhapa. Thanks for your PR.

I'm waiting for a redhat-cne member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@AkashMore08

Copy link
Copy Markdown

Closing in favor of #767 which uses v0.43.0-sec.4 (Go 1.23 compatible) instead of v0.50.0-sec.4 (Go 1.24), avoiding unnecessary go and toolchain version bumps. The release-4.21 branch uses Go 1.23.

@AkashMore08

Copy link
Copy Markdown

Hi @prabhapa, this PR can be closed in favor of #767 which uses v0.43.0-sec.4 (Go 1.23 compatible) instead of v0.50.0-sec.4 (Go 1.24), avoiding unnecessary go and toolchain version bumps. The release-4.21 branch uses Go 1.23.

@prabhapa
prabhapa force-pushed the cve/4.21/OCPBUGS-104041 branch from 59a8f13 to 4a13d9b Compare October 26, 2026 06:46
@prabhapa

Copy link
Copy Markdown
Author

/close

@openshift-ci openshift-ci Bot closed this Oct 26, 2026
@openshift-ci

openshift-ci Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

@prabhapa: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot

Copy link
Copy Markdown

@prabhapa: This pull request references Jira Issue OCPBUGS-104041. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

This PR replaces golang.org/x/net with github.com/openshift-sustaining/net@v0.50.0-sec.4.

Rationale

CVE-2026-33814, a Go HTTP/2 denial of service caused by a malformed SETTINGS_MAX_FRAME_SIZE frame, is fixed upstream in golang.org/x/net v0.53.0, which requires Go 1.25. The release-4.21 branch is built with Go 1.24 and cannot consume that upstream release. The v0.50.0-sec.4 sustaining fork carries the compatible backport for this Go version.

Source

Jira coverage

This shared source change addresses:

  • OCPBUGS-104041 — openshift4/ose-cloud-event-proxy-rhel9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants