Skip to content

fix: read a mission control period the same whatever its case - #1390

Merged
sbillinge merged 1 commit into
regro:mainfrom
sbillinge:mc-periods-ignore-case
Oct 6, 2026
Merged

sbillinge merged 1 commit into
regro:mainfrom
sbillinge:mc-periods-ignore-case

Conversation

@sbillinge

Copy link
Copy Markdown
Contributor

A heading typed by hand says 2026Fall as readily as the 2026fall a build writes, but split_period in mc.py matched the name case sensitively, so a capitalised period was unrecognised, sorted after every real one, and took over the goals section while the archive got a section per spelling. The name is now matched whatever its case, and one spelling is kept: changes() stores a goal's period and first_period as the group's calendar spells them, and the builder and the goals lister read a stored one so. A period written some other way, such as 2026Q3, is left as it was.

A heading typed by hand says 2026Fall as readily as the 2026fall a
build writes, but split_period in mc.py matched the name case
sensitively, so a capitalised period was unrecognised, sorted after
every real one, and took over the goals section while the archive got a
section per spelling.  The name is now matched whatever its case, and
one spelling is kept: changes() stores a goal's period and first_period
as the group's calendar spells them, and the builder and the goals
lister read a stored one so.  A period written some other way, such as
2026Q3, is left as it was.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.29%. Comparing base (4b34f3c) to head (1db53e1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1390      +/-   ##
==========================================
+ Coverage   91.23%   91.29%   +0.05%     
==========================================
  Files          29       29              
  Lines        3308     3330      +22     
==========================================
+ Hits         3018     3040      +22     
  Misses        290      290              
Files with missing lines Coverage Δ
tests/test_mc.py 100.00% <100.00%> (ø)
tests/test_mc_changes.py 100.00% <100.00%> (ø)
tests/test_mc_listers.py 100.00% <ø> (ø)
tests/test_missioncontrolbuilder.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge
sbillinge merged commit 685d8ee into regro:main Oct 6, 2026
7 checks passed
@sbillinge
sbillinge deleted the mc-periods-ignore-case branch October 6, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant