Repository navigation
fix: read a mission control period the same whatever its case - #1390
Merged
Merged
Conversation
A heading typed by hand says 2026Fall as readily as the 2026fall a build writes, but split_period in mc.py matched the name case sensitively, so a capitalised period was unrecognised, sorted after every real one, and took over the goals section while the archive got a section per spelling. The name is now matched whatever its case, and one spelling is kept: changes() stores a goal's period and first_period as the group's calendar spells them, and the builder and the goals lister read a stored one so. A period written some other way, such as 2026Q3, is left as it was. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1390 +/- ##
==========================================
+ Coverage 91.23% 91.29% +0.05%
==========================================
Files 29 29
Lines 3308 3330 +22
==========================================
+ Hits 3018 3040 +22
Misses 290 290
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A heading typed by hand says 2026Fall as readily as the 2026fall a build writes, but split_period in mc.py matched the name case sensitively, so a capitalised period was unrecognised, sorted after every real one, and took over the goals section while the archive got a section per spelling. The name is now matched whatever its case, and one spelling is kept: changes() stores a goal's period and first_period as the group's calendar spells them, and the builder and the goals lister read a stored one so. A period written some other way, such as 2026Q3, is left as it was.