Skip to content

fix: read every note at the end of a mission control goal line - #1391

Merged
sbillinge merged 1 commit into
regro:mainfrom
sbillinge:mc-goal-line-reads-every-note
Oct 6, 2026
Merged

sbillinge merged 1 commit into
regro:mainfrom
sbillinge:mc-goal-line-reads-every-note

Conversation

@sbillinge

Copy link
Copy Markdown
Contributor

The build writes two notes on a goal carried from an earlier period and finished in this one, (carried since ...) and (finished ...), but GOAL_LINE in mc.py consumed only one. The id and the first note then became the goal's words, and the next sync stored them as a new goal. The pattern now takes any number of notes, so the line reads back as the goal it is.

The build writes two notes on a goal carried from an earlier period and
finished in this one, (carried since ...) and (finished ...), but
GOAL_LINE in mc.py consumed only one.  The id and the first note then
became the goal's words, and the next sync stored them as a new goal.
The pattern now takes any number of notes, so the line reads back as
the goal it is.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.28%. Comparing base (4b34f3c) to head (29549a0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1391      +/-   ##
==========================================
+ Coverage   91.23%   91.28%   +0.04%     
==========================================
  Files          29       29              
  Lines        3308     3326      +18     
==========================================
+ Hits         3018     3036      +18     
  Misses        290      290              
Files with missing lines Coverage Δ
tests/test_mc_parser.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge
sbillinge merged commit 883f967 into regro:main Oct 6, 2026
7 checks passed
@sbillinge
sbillinge deleted the mc-goal-line-reads-every-note branch October 6, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant