Repository navigation
fix: write the years of an employment dated with begin_date in the CV - #1393
Merged
sbillinge merged 2 commits intoOct 11, 2026
Merged
Conversation
The cv and resume templates write a span from begin_year and end_year and say present for a year they do not find, so an employment or education entry dated with begin_date and end_date, which the people schema allows, came out as present - present. with_years() in tools.py fills the years from the dates, and cvbuilder.py and resumebuilder.py run every entry through it before the template sees it. Only the years are filled, not the months, since 2008-01-01 to 2025-12-31 is how somebody writes 2008 to 2025. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1393 +/- ##
==========================================
+ Coverage 91.34% 91.36% +0.01%
==========================================
Files 29 29
Lines 3351 3358 +7
==========================================
+ Hits 3061 3068 +7
Misses 290 290
🚀 New features to boost your workflow:
|
…uilders Drop the comments that said what the code already says, and call the lists what they hold. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cv and resume templates write a span from begin_year and end_year and say present for a year they do not find, so an employment or education entry dated with begin_date and end_date, which the people schema allows, came out as present - present. with_years() in tools.py fills the years from the dates, and cvbuilder.py and resumebuilder.py run every entry through it before the template sees it. Only the years are filled, not the months, since 2008-01-01 to 2025-12-31 is how somebody writes 2008 to 2025.