Repository navigation
Mc sync survives a bad document - #1395
Merged
Merged
Conversation
…yncing A line copied, id and all, to where a line is of another kind, such as a finished task copied under an On-deck goal, was noted as a copy and then brought the sync down with a bare StopIteration when the copy was settled against the wrong collection. The reader in mc.py now keeps which kind each id was first written on and refuses such a line with a message naming it and what to do. The collections are written once every document is read, so the crash also lost what every other document said, after each was reported as written. mcsynchelper.py now reports a document it falls over on and goes on, so the rest is still written. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…bad-document # Conflicts: # src/regolith/mc.py
…ction A task copied under a holding section is now refused as being in two places, before its kind is looked at. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1395 +/- ##
==========================================
+ Coverage 91.58% 91.63% +0.05%
==========================================
Files 29 29
Lines 3445 3467 +22
==========================================
+ Hits 3155 3177 +22
Misses 290 290
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.