Skip to content

TEST ONLY - #251

Open
rene wants to merge 2 commits into
masterfrom
test-pr
Open

rene wants to merge 2 commits into
masterfrom
test-pr

Conversation

@rene

@rene rene commented Aug 24, 2026

Copy link
Copy Markdown
Owner

Test

@rene

rene commented Aug 24, 2026

Copy link
Copy Markdown
Owner Author

@claude

@claude

claude Bot commented Aug 24, 2026 •

Copy link
Copy Markdown

Claude finished @rene's task in 16s —— View job


Code Review

  • Analyze PR diff
  • Review changes

The only change in this PR is adding a // FORCE REBUILD comment at the top of pkg/memory-monitor/src/monitor/main.c. This is a stray comment with no functional purpose. See inline comment.

Comment thread pkg/memory-monitor/src/monitor/main.c Outdated
// Copyright (c) 2024 Zededa, Inc.
// SPDX-License-Identifier: Apache-2.0

// FORCE REBUILD

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This // FORCE REBUILD comment serves no functional purpose and should not be merged. It looks like a leftover debugging/CI-triggering artifact. Please remove it before merging.

@claude

claude Bot commented Aug 24, 2026 •

Copy link
Copy Markdown

Claude finished @rene's task in 21s —— View job


Code Review

  • Read PR diff vs origin/master
  • Review the change
  • Post findings

The PR adds a single line to pkg/memory-monitor/src/monitor/main.c:

+// FORCE REBUILD

This is a leftover debug/test marker with no functional effect. It should be removed before merging (or the PR closed, since it's marked "TEST ONLY"). Detailed note posted inline.

No functional, security, or performance concerns beyond the stray comment.

Comment thread pkg/memory-monitor/src/monitor/main.c Outdated
// Copyright (c) 2024 Zededa, Inc.
// SPDX-License-Identifier: Apache-2.0

// FORCE REBUILD

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This // FORCE REBUILD comment appears to be a leftover debug/test marker with no functional purpose. It should be removed before merging.

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Claude finished @rene's task in 23s —— View job


Code Review

  • Read PR diff vs origin/master
  • Review the change
  • Post findings

The PR adds a single stray line to pkg/monitor/Dockerfile:

+# FORCE BUILD

This is a leftover marker (used to bust the Docker build cache) with no functional effect. It should be removed before merging — or the PR closed, since it's marked "TEST ONLY". Inline comment posted with a removal suggestion.

No functional, security, or performance concerns beyond the stray comment.

Comment thread pkg/monitor/Dockerfile Outdated
FROM --platform=$BUILDPLATFORM ${RUST_VERSION} AS toolchain-base
ARG TARGETARCH

# FORCE BUILD

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This # FORCE BUILD comment has no functional purpose — it's a leftover marker used to invalidate the Docker build cache. It should be removed before merging (or the PR closed, since it's marked "TEST ONLY").

Suggested change
# FORCE BUILD

rene added 2 commits October 12, 2026 12:39
Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Claude finished @rene's task in 31s —— View job


Code Review

  • Read PR diff vs origin/master
  • Review the changes
  • Post findings

Two changes in this PR, both appear to be temporary testing artifacts (the commit messages are marked "do not merge"):

  1. .github/workflows/yetus.yml — swaps the Yetus image from the official lfedge/eve-yetus to a personal renezededa/eve-yetus image. This must not be merged to master.
  2. pkg/optee-client/Dockerfile — adds a stray # FORCE BUILD cache-busting comment with no functional purpose.

Inline comments posted. Since this is marked "TEST ONLY", both changes should be reverted before merge (or the PR closed).

-v ${{ github.workspace }}:/workspace \
-v /tmp/gitconfig:/etc/gitconfig \
lfedge/eve-yetus:0.15.1-eve-2 \
renezededa/eve-yetus:0.15.1-eve-2 \

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This points the Yetus check at a personal image (renezededa/eve-yetus) instead of the official lfedge/eve-yetus. This is a temporary testing change and must not be merged to master — it would make CI depend on a personal Docker Hub namespace.

Suggested change
renezededa/eve-yetus:0.15.1-eve-2 \
lfedge/eve-yetus:0.15.1-eve-2 \


FROM lfedge/eve-alpine:080e2b4c683508649d72d2ae9b166153d819ca5d AS build-arm64

# FORCE BUILD

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This # FORCE BUILD comment is a leftover marker used to bust the Docker build cache — it has no functional purpose and should be removed before merging.

Suggested change
# FORCE BUILD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant