Repository navigation
Conversation
| // Copyright (c) 2024 Zededa, Inc. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| // FORCE REBUILD |
There was a problem hiding this comment.
This // FORCE REBUILD comment serves no functional purpose and should not be merged. It looks like a leftover debugging/CI-triggering artifact. Please remove it before merging.
|
Claude finished @rene's task in 21s —— View job Code Review
The PR adds a single line to +// FORCE REBUILDThis is a leftover debug/test marker with no functional effect. It should be removed before merging (or the PR closed, since it's marked "TEST ONLY"). Detailed note posted inline. No functional, security, or performance concerns beyond the stray comment. |
| // Copyright (c) 2024 Zededa, Inc. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| // FORCE REBUILD |
There was a problem hiding this comment.
This // FORCE REBUILD comment appears to be a leftover debug/test marker with no functional purpose. It should be removed before merging.
b462207 to
ebdf493
Compare
|
Claude finished @rene's task in 23s —— View job Code Review
The PR adds a single stray line to +# FORCE BUILDThis is a leftover marker (used to bust the Docker build cache) with no functional effect. It should be removed before merging — or the PR closed, since it's marked "TEST ONLY". Inline comment posted with a removal suggestion. No functional, security, or performance concerns beyond the stray comment. |
| FROM --platform=$BUILDPLATFORM ${RUST_VERSION} AS toolchain-base | ||
| ARG TARGETARCH | ||
|
|
||
| # FORCE BUILD |
There was a problem hiding this comment.
This # FORCE BUILD comment has no functional purpose — it's a leftover marker used to invalidate the Docker build cache. It should be removed before merging (or the PR closed, since it's marked "TEST ONLY").
| # FORCE BUILD |
Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
|
Claude finished @rene's task in 31s —— View job Code Review
Two changes in this PR, both appear to be temporary testing artifacts (the commit messages are marked "do not merge"):
Inline comments posted. Since this is marked "TEST ONLY", both changes should be reverted before merge (or the PR closed). |
| -v ${{ github.workspace }}:/workspace \ | ||
| -v /tmp/gitconfig:/etc/gitconfig \ | ||
| lfedge/eve-yetus:0.15.1-eve-2 \ | ||
| renezededa/eve-yetus:0.15.1-eve-2 \ |
There was a problem hiding this comment.
This points the Yetus check at a personal image (renezededa/eve-yetus) instead of the official lfedge/eve-yetus. This is a temporary testing change and must not be merged to master — it would make CI depend on a personal Docker Hub namespace.
| renezededa/eve-yetus:0.15.1-eve-2 \ | |
| lfedge/eve-yetus:0.15.1-eve-2 \ |
|
|
||
| FROM lfedge/eve-alpine:080e2b4c683508649d72d2ae9b166153d819ca5d AS build-arm64 | ||
|
|
||
| # FORCE BUILD |
There was a problem hiding this comment.
This # FORCE BUILD comment is a leftover marker used to bust the Docker build cache — it has no functional purpose and should be removed before merging.
| # FORCE BUILD |
Test