Skip to content

[DO NOT MERGE] test: cache-export fix + Zot push (mkconf rebuild) - #256

Merged
europaul merged 2 commits into
masterfrom
test/cache-export-pkg-org
Oct 7, 2026
Merged

europaul merged 2 commits into
masterfrom
test/cache-export-pkg-org

Conversation

@europaul

@europaul europaul commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Test-only PR, do not merge. Use #255 for the actual fix.

Carries the cache-export fix from #255 plus a comment-only change to pkg/mkconf/Dockerfile so the PR build is triggered (the workflow ignores .github/**-only changes) and one small package gets built and pushed to the Zot registry on kratos. Everything else is pulled through Zot, and the eve jobs exercise the LINUXKIT_PKG_ORG-aware cache-export.

What to look for:

Context: EV-2862.

🤖 Generated with Claude Code

europaul and others added 2 commits October 7, 2026 15:47
The build-eve action and the riscv64 build step export the EVE image
from the linuxkit cache under the hardcoded name lfedge/eve:<version>.
When a runner sets LINUXKIT_PKG_ORG (e.g. to point linuxkit at a local
registry namespace such as 10.208.13.77:5050/lfedge), linuxkit tags the
built image under that org instead, and 'linuxkit cache export' fails
with 'could not find image or index for docker.io/lfedge/eve:<version>'
because the cache lookup is an exact-name match.

Derive the org from LINUXKIT_PKG_ORG, falling back to lfedge, so the
export asks for the name linuxkit actually wrote.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Paul Gaiduk <paulg@zededa.com>
…ort fix)

Test-only. Changes pkg/mkconf's hash so CI builds and pushes one small
package to the Zot registry, while every other package is pulled through
it, and the eve jobs exercise the LINUXKIT_PKG_ORG-aware cache-export.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Paul Gaiduk <paulg@zededa.com>
@europaul
europaul requested a review from eriknordmark as a code owner October 7, 2026 13:49
@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Claude finished @europaul's task in 1m 12s —— View job


Review

Scope: Test-only PR (correctly marked [DO NOT MERGE]). Carries the cache-export fix from #255 plus a comment-only rebuild trigger.

Tasks

  • Read PR diff vs origin/master
  • Trace LINUXKIT_PKG_ORG usage and make eve / cache-export image naming
  • Check for other un-updated lfedge/eve cache-export references
  • Post review

Findings

The fix is correct and low-risk. IMAGE=${LINUXKIT_PKG_ORG:-lfedge}/eve:... falls back to lfedge when the var is unset, so default behavior is unchanged, and both shell: bash steps evaluate the expansion correctly.

A couple of points worth confirming while testing (not blockers):

  1. Correctness hinges on make eve tagging with the same org. The exported IMAGE only resolves if the image make eve produced is actually tagged ${LINUXKIT_PKG_ORG}/eve:.... pkg/eve/build.yml hardcodes org: lfedge, so this relies on linuxkit honoring the LINUXKIT_PKG_ORG env override at build time. That's exactly what this PR exercises — verify the "Export docker container" step finds the image rather than erroring with a missing/lfedge-prefixed tag.

  2. Both eve cache-export sites are covered — .github/actions/build-eve/action.yml:61 and .github/workflows/build.yml:448. No other lfedge/eve cache-export call was left behind. (assets.yml still references lfedge/eve:..., but that's a separate publish workflow outside this PR's scope — worth keeping in mind for the real fix in github: honour LINUXKIT_PKG_ORG when exporting the EVE image from cache #255 if custom-org publishing is ever needed there.)

  3. pkg/mkconf/Dockerfile — the added comment is pure test scaffolding to defeat the .github/**-only path filter; it must be dropped before github: honour LINUXKIT_PKG_ORG when exporting the EVE image from cache #255 merges (already implied by [DO NOT MERGE]).

No bugs or security concerns. Nothing blocking for a test PR.
· branch test/cache-export-pkg-org

@europaul
europaul merged commit a5cc10a into master Oct 7, 2026
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant