Repository navigation
Fullscreen - #28
Fullscreen#28
Conversation
|
Claude finished @rene's task —— View job Code Review
FindingsBug —
|
| Severity | File | Issue |
|---|---|---|
| Bug | src/gui/sdl/gui.c:201 |
rnes_gui.scale set to 0/negative instead of 1 for default scale |
| Bug | src/gui/sdl/gui.c:216 |
SDL_RenderSetLogicalSize called before NULL check on renderer |
| Bug | src/gui/sdl/gui.c:237 |
gui_set_fullscreen called on error path where win/renderer may be NULL |
| Minor | src/interface/posix/rNES.c:308 |
Stale @param docstring for gui_th_loop |
| Nit | src/gui/sdl/gui.c:334 |
Redundant SDL_KEYDOWN type check inside the F12 case |
The fullscreen logic itself (SDL_WINDOW_FULLSCREEN_DESKTOP + SDL_RenderSetLogicalSize for letterboxing, cursor hiding, F12 toggle, struct _gui_args refactor) is well-structured. The scale regression in the scale <= 0 branch is the most important fix needed before merging.
c397da8 to
b95b9e5
Compare
|
Claude finished @rene's task —— View job Code Review
FindingsBug —
|
| Severity | Location | Issue |
|---|---|---|
| Bug | src/gui/sdl/gui.c:216 |
SDL_RenderSetLogicalSize called before NULL-checking the renderer |
| Nit | src/gui/sdl/gui.c:336 |
Redundant SDL_KEYDOWN type check inside SDLK_F12 case |
The overall fullscreen implementation is clean. The struct _gui_args refactor, SDL_WINDOW_FULLSCREEN_DESKTOP + SDL_RenderSetLogicalSize for letterboxing, cursor hiding, and F12 toggle are all well-structured. The previously reported scale regression (rnes_gui.scale = scale storing 0) and missing return -1 have already been fixed in the current diff — the code correctly stores 1 and returns early on error. The one actionable bug remaining is the NULL renderer being passed to SDL_RenderSetLogicalSize before the NULL check.
- Add -f / --fullscreen argument - Use F12 to toggle fullscreen mode during runtime Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
Update documentation about the full screen mode. Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
Handle the new fullscreen parameter. Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
Full screen mode