Repository navigation
Windows: flush the v1 backup through a writable handle - #58
Merged
Merged
Conversation
… host The v1 backup before migrating has only ever run on Linux and macOS.
Windows refuses FlushFileBuffers on a read-only handle, so every 0.6 data dir failed its pre-migration backup there and never opened.
A Windows checkout converts it to CRLF, so the staleness check failed there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows refuses
FlushFileBufferson a read-only handle.write_backupflushed the.v1-backup.tmpcopy throughFile::open, so on Windows every 0.6 data dir failed its pre-migration backup withErrorMigrationFailedand never opened. Reported by a Windows tester on Entonal Studio 2.0.0-alpha.14 (replicant-client 0.7.1): the library would not open and the user's tunings did not show. The v1 file is untouched, because the backup runs before migration 015.test:runs the unit tests onwindows-latestas well as Linux, and adds a host test that attaches to a v1 data dir throughhost::attach(canonicalised path, backup, migration).fix:flushes the copy through a handle opened for writing.The test commit is pushed first, so the Windows job should fail on
attaching_to_a_v1_data_dir_backs_it_up_and_migrates_itbefore the fix lands. This is also the first Windows run of the full unit suite, so unrelated Windows failures may show up.