Merge service files in sdk-tests shadow jar - #449
Merged
Merged
Conversation
Since #448, RestateDeployer checks cluster state via gRPC. In the sdk-tests fat jar, grpc-netty-shaded's META-INF/services/io.grpc.NameResolverProvider overwrote grpc-core's, leaving only UdsNameResolverProvider. The default scheme became 'unix', so building a channel to localhost:<port> failed with "Address types of NameResolver 'unix' ... not supported by transport", timing out deployment of every SDK test class. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since #448,
RestateDeployer.waitForMetadataClusterBeingReadychecks cluster state over gRPC. In thesdk-testsshadow jar,META-INF/services/io.grpc.NameResolverProviderfromgrpc-netty-shadedoverwrote the one fromgrpc-core, so onlyUdsNameResolverProviderwas registered. The default scheme becameunix, and every channel tolocalhost:<port>failed:As a result, every SDK test class, in every SDK and every config, timed out in
beforeAll(e.g. https://github.com/restatedev/restate/actions/runs/36150936597). The e2e suites weren't affected because they run on the Gradle test classpath, not the fat jar.Fix
Add
mergeServiceFiles()totasks.shadowJar. In the rebuilt jar,io.grpc.NameResolverProviderlists bothDnsNameResolverProviderandUdsNameResolverProvider, andPickFirstLoadBalancerProvideris back inio.grpc.LoadBalancerProvider. Building a channel tolocalhost:<port>from the jar now works.🤖 Generated with Claude Code