Validate live OpenAPI contracts and generated clients - #452
Closed
tillrohrmann wants to merge 2 commits into
Closed
tillrohrmann wants to merge 2 commits into
tillrohrmann wants to merge 2 commits into
Conversation
Fetch Admin, Service, Virtual Object, and Workflow specifications from the candidate Restate instance. Generate and compile Java clients, then exercise HTTP deployment responses, resume/restart selectors, and ingress operations against the live cluster instead of asserting on schema JSON layout. Refresh the existing Admin specification and use it as the baseline for a pinned oasdiff compatibility check. Align OpenAPI Generator versions, remove stale generated sources, and retain specifications and compiler diagnostics in the existing test reports. Document local execution and baseline updates. The checks run through the existing default E2E suite. Keep the setup-java v4 update without adding separate CI steps or negative-control tests. This fixes restatedev#451.
tillrohrmann
force-pushed
the
issues/451
branch
from
October 2, 2026 22:02
9643de1 to
610166a
Compare
Use raw HTTP requests when listing and updating deployments in the old-server phase. The current generated Admin client cannot deserialize v1.7 deployment responses without the type discriminator, even when an update's return value is ignored. Replace the legacy v2 PUT with PATCH, which v1.7.3 already supports. Document why raw requests are necessary and when they can be replaced with the generated Admin API.
Collaborator
|
Took some bits in #454 then gonna close as discussed offline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetch Admin, Service, Virtual Object, and Workflow specifications from the candidate Restate instance. Generate and compile Java clients, then exercise HTTP deployment responses, resume/restart selectors, and ingress operations against the live cluster instead of asserting on schema JSON layout.
Refresh the existing Admin specification and use it as the baseline for a pinned oasdiff compatibility check. Align OpenAPI Generator versions, remove stale generated sources, and retain specifications and compiler diagnostics in the existing test reports. Document local execution and baseline updates.
The checks run through the existing default E2E suite. Keep the setup-java v4 update without adding separate CI steps or negative-control tests.
This fixes #451