fix: Reject duplicate handler names at registration - #234
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject duplicate handler names at registration
Fixes #10
Registering two handlers with the same name on a
Service,VirtualObjectorWorkflowsilently replaced the first handler with the second. The decorator now raises aValueErrorwhen a handler with the same name is already registered, which surfaces the mistake when the module is imported.The error message follows the one
Endpoint.bindraises for duplicate service names, for exampleHandler greet already exists in Greeter.Testing
tests/duplicate_handlers.pycoversService,VirtualObjectandWorkflow, including a workflowmainhandler and a shared handler that use the same name.The tests fail without the change (
DID NOT RAISE ValueError, 3 failed) and pass with it (3 passed).