Repository navigation
fix(delegate): use tools.delegate_tool_toolsets.DEFAULT_TOOLSETS - #2
Merged
Merged
Conversation
Hermes 2026-09 moved DEFAULT_TOOLSETS out of tools.delegate_tool into tools.delegate_tool_toolsets. Reading dt.DEFAULT_TOOLSETS now goes through the plugin-compat shim and emits HermesPluginCompatWarning on every load; the shim is removed on 2026-09-14, after which the old path raises AttributeError and the code_intel force-append would silently stop working (swallowed by the surrounding try/except). Import the new module directly, falling back to the old location so the plugin keeps working on pre-2026-09 Hermes builds.
Owner
|
Thanks for the compatibility fix! Merged as 52e738f. Verification:
This keeps the delegate integration working when the deprecated DEFAULT_TOOLSETS shim is removed while retaining compatibility with older Hermes builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hermes 2026-09 moved DEFAULT_TOOLSETS out of tools.delegate_tool into tools.delegate_tool_toolsets. Reading dt.DEFAULT_TOOLSETS now goes through the plugin-compat shim and emits HermesPluginCompatWarning on every load; the shim is removed on 2026-09-14, after which the old path raises AttributeError and the code_intel force-append would silently stop working (swallowed by the surrounding try/except).
Import the new module directly, falling back to the old location so the plugin keeps working on pre-2026-09 Hermes builds.