Skip to content

fix(delegate): use tools.delegate_tool_toolsets.DEFAULT_TOOLSETS - #2

Merged
rewasa merged 1 commit into
rewasa:mainfrom
fastfinge:fix/delegate-toolsets-moved
Sep 21, 2026
Merged

rewasa merged 1 commit into
rewasa:mainfrom
fastfinge:fix/delegate-toolsets-moved

Conversation

@fastfinge

Copy link
Copy Markdown
Contributor

Hermes 2026-09 moved DEFAULT_TOOLSETS out of tools.delegate_tool into tools.delegate_tool_toolsets. Reading dt.DEFAULT_TOOLSETS now goes through the plugin-compat shim and emits HermesPluginCompatWarning on every load; the shim is removed on 2026-09-14, after which the old path raises AttributeError and the code_intel force-append would silently stop working (swallowed by the surrounding try/except).

Import the new module directly, falling back to the old location so the plugin keeps working on pre-2026-09 Hermes builds.

Hermes 2026-09 moved DEFAULT_TOOLSETS out of tools.delegate_tool into
tools.delegate_tool_toolsets. Reading dt.DEFAULT_TOOLSETS now goes through
the plugin-compat shim and emits HermesPluginCompatWarning on every load;
the shim is removed on 2026-09-14, after which the old path raises
AttributeError and the code_intel force-append would silently stop
working (swallowed by the surrounding try/except).

Import the new module directly, falling back to the old location so the
plugin keeps working on pre-2026-09 Hermes builds.
@rewasa
rewasa merged commit 52e738f into rewasa:main Sep 21, 2026
4 checks passed
@rewasa

rewasa commented Sep 21, 2026

Copy link
Copy Markdown
Owner

Thanks for the compatibility fix! Merged as 52e738f.

Verification:

This keeps the delegate integration working when the deprecated DEFAULT_TOOLSETS shim is removed while retaining compatibility with older Hermes builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants