Repository navigation
fix(grillme): vendor gcp-vertex.env for BYOA overlay gap - #8
Merged
Merged
Conversation
Harness file validation failed because host_files pointed at .env/gcp-vertex.env, which v0.36 never overlays. The install scaffold has no env/ directory; that file lives in fullsend-ai/agents and is only present when a built-in agent is resolved remotely. Copy the Vertex env into custom/env and point the grillme harness at it. Co-authored-by: Cursor <cursoragent@cursor.com>
|
🤖 Finished Review · ✅ Success · Started 5:01 PM UTC · Completed 5:13 PM UTC Commit: |
|
Looks good to me Labels: PR fixes a harness configuration bug (missing vendored env file) |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
ready-for-merge
|
🤖 Finished Retro · ✅ Success · Started 5:28 PM UTC · Completed 5:38 PM UTC Commit: |
Retro: PR #8 — fix(grillme): vendor gcp-vertex.env for BYOA overlay gapWorkflow outcome: smooth, no proposals needed. This was a human-authored, 2-file config fix that the review agent correctly approved on the first pass with no rework. Timeline
What went well
Evidence for existing issues (no new proposals needed)
Agents repo: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
/fs-grillmeharness failure on run 32504641405:v0.36 overlays
internal/scaffold/fullsend-repointo.fullsend/. That scaffold hasscripts/,profiles/,providers/— noenv/.gcp-vertex.envlives infullsend-ai/agentsand only appears when a built-in agent is fetched remotely. Grillme is a local BYOA harness, so the file was missing.This PR vendors the upstream Vertex env under
custom/env/gcp-vertex.envand points the harnesshost_filesat it.Test plan
/fs-grillmeon docs: OpenSpec for task status workflow #7Made with Cursor