Bump Cargo.lock with the rest of the version - #269
Merged
Merged
Conversation
bump-version.sh writes the new version into pyproject.toml, tauri.conf.json, Cargo.toml and frontend/package.json. It does not touch Cargo.lock, which carries the crate's own version too. The committed lock said 2.8.3 while Cargo.toml said 2.9.1, so cargo rewrote it on the first build and left the tree dirty. That is noise on every checkout that builds, and noise of exactly the kind that teaches people to discard a file without reading it -- I did that twice during this review before looking at what it was. cargo update --offline -p kaisho-desktop updates that one entry: --offline so a version bump does not need the network, -p so no dependency moves as a side effect. The lock is brought to 2.9.1 in the same commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bump-version.shwrites the new version intopyproject.toml,tauri.conf.json,Cargo.tomlandfrontend/package.json. It does not touchCargo.lock, which carries the crate's own version too.The committed lock said
2.8.3whileCargo.tomlsaid2.9.1, so cargo rewrote it on the first build and left the tree dirty:That is noise on every checkout that builds, and noise of exactly the kind that teaches people to
git checkout --a file without reading it. I did that twice myself during this review before looking at what it was.cargo update --offline -p kaisho-desktopupdates that one entry:--offlineso a version bump does not need the network,-pso no dependency moves as a side effect. The lock is brought to 2.9.1 in the same commit.