Repository navigation
Take the actions off Node 20 - #271
Merged
Merged
Conversation
Every run carries the same annotation twice: checkout@v4, setup-node@v4 and pnpm/action-setup@v4 target Node 20, which is deprecated, and the runners are already forcing them onto Node 24. The note is a deadline rather than a preference. Bumped to the majors that target a supported runtime: checkout v5, setup-python v6, setup-node v5, upload-artifact v5, download-artifact v5. pnpm/action-setup has no v5, so it is pinned to v4.2.0, the release that runs on Node 24. No behaviour change intended: same inputs, same steps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every run carries this annotation, twice:
The runners are already substituting Node 24 for these; the note is a deadline, not a preference. Bumped to the majors that target a supported runtime:
pnpm/action-setuphas no v5; pinning the patch gets the release that runs on Node 24.No behaviour change intended — same inputs, same steps. The desktop build is the one to watch, since
upload-artifactanddownload-artifactv5 changed their defaults around artifact overwrite; this workflow uploads one artifact per matrix leg under a distinct name and downloads them all in the release job, which is the pattern v5 is built for.