Repository navigation
Conversation
GroupSettings(link="precision") links a localization when its distance from the running position satisfies r^2 < k^2 (s_h^2 + s^2), clamped to [dx_min, dx_max] (defaults k = 2.5, 10 and 150 nm). The test runs in the C++ walk and in the chunked linker's seam repair. Unlike SMAP's connectsinglesigma, the candidate's precision and the running position's (propagated through the walk's mean) are used, not the seed's twice. A table without a precision column falls back to the box with a warning. The grouping dialog gains "link by" and shows the mode's own fields. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UHPexokxDqWV5qNmdFKY9R
The docstring and the test comment still said it was not wired into group(); it is, through GroupSettings.link_chunks (8 by default). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UHPexokxDqWV5qNmdFKY9R
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Grouping gets a second way to link, beside the fixed box: link by precision, SMAP's
locprecmode (connectsinglesigma.c). A localization joins a blink when its distancerfrom the running position satisfiesDefaults:
k = 2.5(SMAP's),dx_min = 10 nm,dx_max = 150 nm. Fixed distance stays the default mode.csrc/group.hpp,csrc/group.cpp: the precision test inside the C++ walk. It is optional (var,k2,r2min), and the box path doesn't change.src/smappy/group.py:GroupSettingsgetslink,k,dx_minanddx_max.connect(..., precision=, k=, dx_min=). The precision is read in the same unit as the positions (xy_err_nmorxy_err_pix).src/smappy/_group_chunked.py: the seam repair carries the running variance and applies the same test.src/smappy/gui/dialogs.py: the grouping dialog gets a link by choice and shows only the fields of the chosen mode.NOTES.mdunder Grouping, and the module docstrings._group_chunked.pyand a test comment, that the chunked linker "is not wired intogroup()". It is, throughlink_chunks(8 by default).Departures from SMAP
(σ_h² + σ²)/4.ritself. SMAP floors each2.5σat the minimum separately, so its smallest radius was really√2 · dx_min.Behaviour to know
r²/(σ_h² + σ²)is χ² with 2 degrees of freedom, so a fraction1 − exp(−k²/2)of links is kept: 95.6% at k = 2.5. A test checks this.dx_max. A table with no precision column falls back to the box and shows a warning, because every file is grouped as it opens.Tests
7 new tests in
tests/test_group.py:The full suite passes with Qt offscreen: 1311 passed, 4 skipped.
🤖 Generated with Claude Code
https://claude.ai/code/session_01UHPexokxDqWV5qNmdFKY9R
Generated by Claude Code