Skip to content

Memoize Monaco options in AdvancedCodeEditor#1007

Open
Jerry-Tekh wants to merge 1 commit into
rinafcode:mainfrom
Jerry-Tekh:fix/976-memoize-monaco-options
Open

Memoize Monaco options in AdvancedCodeEditor#1007
Jerry-Tekh wants to merge 1 commit into
rinafcode:mainfrom
Jerry-Tekh:fix/976-memoize-monaco-options

Conversation

@Jerry-Tekh

Copy link
Copy Markdown

Summary

  • memoize the Monaco editor options so content updates keep a stable configuration reference
  • limit option invalidation to font size, autocomplete, and language indentation changes
  • add regression coverage for content and editor-setting updates

Testing

  • node_modules/.bin/tsc --noEmit
  • node_modules/.bin/eslint src/components/code/AdvancedCodeEditor.tsx src/components/code/__tests__/AdvancedCodeEditor.test.tsx --no-ignore
  • node_modules/.bin/prettier --check src/components/code/AdvancedCodeEditor.tsx src/components/code/__tests__/AdvancedCodeEditor.test.tsx
  • node_modules/.bin/vitest run src/components/code/__tests__/AdvancedCodeEditor.test.tsx

Closes #976

@drips-wave

drips-wave Bot commented Jul 27, 2026

Copy link
Copy Markdown

@Jerry-Tekh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Memoize the Monaco options object in AdvancedCodeEditor

1 participant