Repository navigation
Cargo.lock for 1.31.0; CI fails if Cargo.lock is out of date - #10
Merged
Merged
Conversation
- Cargo.lock had raftcli 1.30.0 after the bump to 1.31.0 (updated with cargo update -p raftcli --offline, which changes only raftcli's own entry). - The test workflow builds with --locked, so a version bump (or dependency change) without its Cargo.lock fails CI rather than going unnoticed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cargo.lockbrought up to 1.31.0. It still had raftcli at 1.30.0 after the version bump. Updated withcargo update -p raftcli --offline, which changes only raftcli's own entry and upgrades no dependencies.--locked(cargo test --all-targets --locked, and the scaffold step'scargo run --locked). A version bump or dependency change without itsCargo.locknow fails the checks instead of going unnoticed.To bump the version from now on: edit
Cargo.toml, runcargo update -p raftcli --offline, and commit both files. Or usecargo set-version(cargo-edit), which does both.Tested
cargo test --all-targets --lockedon this branch: all 144 tests pass.cargo check --lockedonmainbefore this change fails ("the lock file ... needs to be updated but --locked was passed"), so the check does catch it.🤖 Generated with Claude Code