Repository navigation
Devdoc: the BLE notification packet loss was a firmware bug - #6
Merged
Merged
Conversation
Replies by notification lost a packet from messages of 4 KB or more. That was RaftSysMods passing NimBLE a null buffer when its pool ran out (fixed after 1.27.0), not Windows. Notes when RaftCLI still needs indications, and that notifications for downloads might be worth measuring. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devdocs/fs-over-serial-ws-ble-plan.mdsaid that replies by notification lost a packet from messages of 4 KB or more (seen from Windows), which is why RaftCLI keeps replies on indications.That was a firmware bug, fixed in robdobsn/RaftSysMods#12. When notifications used up NimBLE's packet buffers, the firmware passed NimBLE a null buffer, which NimBLE takes to mean "send the characteristic's value" (empty) while reporting success.
The update notes:
Docs only.
🤖 Generated with Claude Code